[scudo] lower quarantine default sizes

Kostya Kortchinsky · Kostya Kortchinsky · commit 432b8dd8addf · 2017-05-18T20:47:35.000Z
Summary: After discussing the current defaults with a couple of parties, the consensus is that they are too high. 1Mb of quarantine has about a 4Mb impact on PSS, so memory usage goes up quickly. This is obviously configurable, but the default value should be more "approachable", so both the global size and the thread local size are 1/4 of what they used to be. Reviewers: alekseyshl, kcc Reviewed By: alekseyshl Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D33321 llvm-svn: 303380
diff --git a/compiler-rt/lib/scudo/scudo_flags.cpp b/compiler-rt/lib/scudo/scudo_flags.cpp
@@ -68,7 +68,7 @@ void initFlags() {
   // Sanity checks and default settings for the Quarantine parameters.
 
   if (f->QuarantineSizeMb < 0) {
-    const int DefaultQuarantineSizeMb = FIRST_32_SECOND_64(16, 64);
+    const int DefaultQuarantineSizeMb = FIRST_32_SECOND_64(4, 16);
     f->QuarantineSizeMb = DefaultQuarantineSizeMb;
   }
   // We enforce an upper limit for the quarantine size of 4Gb.
@@ -77,7 +77,7 @@ void initFlags() {
   }
   if (f->ThreadLocalQuarantineSizeKb < 0) {
     const int DefaultThreadLocalQuarantineSizeKb =
-        FIRST_32_SECOND_64(256, 1024);
+        FIRST_32_SECOND_64(64, 256);
     f->ThreadLocalQuarantineSizeKb = DefaultThreadLocalQuarantineSizeKb;
   }
   // And an upper limit of 128Mb for the thread quarantine cache.

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ void initFlags() {`
`68`	`68`	`// Sanity checks and default settings for the Quarantine parameters.`
`69`	`69`
`70`	`70`	`if (f->QuarantineSizeMb < 0) {`
`71`		`- const int DefaultQuarantineSizeMb = FIRST_32_SECOND_64(16, 64);`
	`71`	`+ const int DefaultQuarantineSizeMb = FIRST_32_SECOND_64(4, 16);`
`72`	`72`	`f->QuarantineSizeMb = DefaultQuarantineSizeMb;`
`73`	`73`	`}`
`74`	`74`	`// We enforce an upper limit for the quarantine size of 4Gb.`
`@@ -77,7 +77,7 @@ void initFlags() {`
`77`	`77`	`}`
`78`	`78`	`if (f->ThreadLocalQuarantineSizeKb < 0) {`
`79`	`79`	`const int DefaultThreadLocalQuarantineSizeKb =`
`80`		`- FIRST_32_SECOND_64(256, 1024);`
	`80`	`+ FIRST_32_SECOND_64(64, 256);`
`81`	`81`	`f->ThreadLocalQuarantineSizeKb = DefaultThreadLocalQuarantineSizeKb;`
`82`	`82`	`}`
`83`	`83`	`// And an upper limit of 128Mb for the thread quarantine cache.`