Remove unnecessary conditions as suggested by clang-tidy. NFC

Xazax-hun · Xazax-hun · commit 43b72d538f9f · 2017-05-01T16:18:42.000Z
Patch by: Gergely Angeli! Differential Revision: https://reviews.llvm.org/D31936 llvm-svn: 301807
diff --git a/llvm/lib/CodeGen/DFAPacketizer.cpp b/llvm/lib/CodeGen/DFAPacketizer.cpp
@@ -213,10 +213,8 @@ VLIWPacketizerList::VLIWPacketizerList(MachineFunction &mf,
 
 
 VLIWPacketizerList::~VLIWPacketizerList() {
-  if (VLIWScheduler)
-    delete VLIWScheduler;
-  if (ResourceTracker)
-    delete ResourceTracker;
+  delete VLIWScheduler;
+  delete ResourceTracker;
 }
 
 
diff --git a/llvm/lib/Support/SourceMgr.cpp b/llvm/lib/Support/SourceMgr.cpp
@@ -51,9 +51,7 @@ static LineNoCacheTy *getCache(void *Ptr) {
 }
 
 SourceMgr::~SourceMgr() {
-  // Delete the line # cache if allocated.
-  if (LineNoCacheTy *Cache = getCache(LineNoCache))
-    delete Cache;
+  delete getCache(LineNoCache);
 }
 
 unsigned SourceMgr::AddIncludeFile(const std::string &Filename,
diff --git a/llvm/lib/Target/TargetLoweringObjectFile.cpp b/llvm/lib/Target/TargetLoweringObjectFile.cpp
@@ -44,7 +44,7 @@ void TargetLoweringObjectFile::Initialize(MCContext &ctx,
                                           const TargetMachine &TM) {
   Ctx = &ctx;
   // `Initialize` can be called more than once.
-  if (Mang != nullptr) delete Mang;
+  delete Mang;
   Mang = new Mangler();
   InitMCObjectFileInfo(TM.getTargetTriple(), TM.isPositionIndependent(),
                        TM.getCodeModel(), *Ctx);

Original file line number	Diff line number	Diff line change
`@@ -213,10 +213,8 @@ VLIWPacketizerList::VLIWPacketizerList(MachineFunction &mf,`
`213`	`213`
`214`	`214`
`215`	`215`	`VLIWPacketizerList::~VLIWPacketizerList() {`
`216`		`- if (VLIWScheduler)`
`217`		`- delete VLIWScheduler;`
`218`		`- if (ResourceTracker)`
`219`		`- delete ResourceTracker;`
	`216`	`+ delete VLIWScheduler;`
	`217`	`+ delete ResourceTracker;`
`220`	`218`	`}`
`221`	`219`
`222`	`220`
Original file line number	Diff line number	Diff line change
`@@ -51,9 +51,7 @@ static LineNoCacheTy getCache(void Ptr) {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`SourceMgr::~SourceMgr() {`
`54`		`- // Delete the line # cache if allocated.`
`55`		`- if (LineNoCacheTy *Cache = getCache(LineNoCache))`
`56`		`- delete Cache;`
	`54`	`+ delete getCache(LineNoCache);`
`57`	`55`	`}`
`58`	`56`
`59`	`57`	`unsigned SourceMgr::AddIncludeFile(const std::string &Filename,`