Skip to content

Commit

Permalink
[mips][ias] Enable IAS by default for N64 on Debian mips64el.
Browse files Browse the repository at this point in the history
Unfortunately we can't enable it for all N64 because it is not yet possible to
distinguish N32 from N64 from the triple on other environments.

N64 has been confirmed to produce identical (within reason) objects to GAS
during stage 2 of compiler recursion on N64-abi Fedora. Unfortunately,
Fedora's triples do not distinguish N32 from N64 so I can't enable it by
default there. I'm currently repeating this testing for Debian mips64el but
it's very unlikely to produce a different result.

Patch by: Daniel Sanders

Reviewers: sdardis

Differential Review: https://reviews.llvm.org/D22679

llvm-svn: 281610
  • Loading branch information
Simon Dardis committed Sep 15, 2016
1 parent fc3f8f5 commit 9edf96e
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions clang/lib/Driver/ToolChains.cpp
Original file line number Diff line number Diff line change
@@ -2778,6 +2778,13 @@ bool Generic_GCC::IsIntegratedAssemblerDefault() const {
case llvm::Triple::mips:
case llvm::Triple::mipsel:
return true;
case llvm::Triple::mips64:
case llvm::Triple::mips64el:
// Enabled for Debian mips64/mips64el only. Other targets are unable to
// distinguish N32 from N64.
if (getTriple().getEnvironment() == llvm::Triple::GNUABI64)
return true;
return false;
default:
return false;
}

0 comments on commit 9edf96e

Please sign in to comment.