[analyzer] Fix scan-build to handle missing output directories.

devincoughlin · devincoughlin · commit 932d88ca0517 · 2015-11-11T20:39:03.000Z
Cwd::abs_path has a somewhat tricky semantics: if it's operand directory does not exist, it'll return undefined (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=257568). This may cause scan-build to silently ignore output directory (specified with -o) and use /tmp instead of trying to create directory. This tiny patch fixes the problem. A patch by Yury Gribov! Differential Revision: http://reviews.llvm.org/D14535 llvm-svn: 252797
diff --git a/clang/tools/scan-build/scan-build b/clang/tools/scan-build/scan-build
@@ -1478,7 +1478,9 @@ sub ProcessArgs {
 
       # Construct an absolute path.  Uses the current working directory
       # as a base if the original path was not absolute.
-      $Options{OutputDir} = abs_path(shift @$Args);
+      my $OutDir = shift @$Args;
+      mkpath($OutDir) unless (-e $OutDir);  # abs_path wants existing dir
+      $Options{OutputDir} = abs_path($OutDir);
 
       next;
     }

Original file line number	Diff line number	Diff line change
`@@ -1478,7 +1478,9 @@ sub ProcessArgs {`
`1478`	`1478`
`1479`	`1479`	`# Construct an absolute path. Uses the current working directory`
`1480`	`1480`	`# as a base if the original path was not absolute.`
`1481`		`- $Options{OutputDir} = abs_path(shift @$Args);`
	`1481`	`+ my $OutDir = shift @$Args;`
	`1482`	`+ mkpath($OutDir) unless (-e $OutDir); # abs_path wants existing dir`
	`1483`	`+ $Options{OutputDir} = abs_path($OutDir);`
`1482`	`1484`
`1483`	`1485`	`next;`
`1484`	`1486`	`}`