[ARM] Error out on apple darwin platforms if float-abi is "hard".

ahatanaka · ahatanaka · commit bbede731a5b2 · 2015-08-24T19:50:35.000Z
Error out if the user tries to use float-abi="hard" since it isn't supported on darwin platforms. Previously clang issued no warnings or erros and just passed the option to the backend, which had no effect on code generation for targets using apcs. rdar://problem/22257950 Differential Revision: http://reviews.llvm.org/D12155 llvm-svn: 245866
diff --git a/clang/lib/Driver/Tools.cpp b/clang/lib/Driver/Tools.cpp
@@ -582,6 +582,10 @@ StringRef tools::arm::getARMFloatABI(const Driver &D, const ArgList &Args,
         FloatABI = "soft";
       }
     }
+
+    if (Triple.isOSDarwin() && FloatABI == "hard")
+      D.Diag(diag::err_drv_unsupported_opt_for_target) << A->getAsString(Args)
+                                                       << Triple.getArchName();
   }
 
   // If unspecified, choose the default based on the platform.
diff --git a/clang/test/Driver/arm-float-abi.c b/clang/test/Driver/arm-float-abi.c
@@ -0,0 +1,5 @@
+// RUN: not %clang %s -target armv7-apple-ios -mfloat-abi=hard 2>&1 | FileCheck -check-prefix=ARMV7-HARD %s
+// RUN: %clang %s -target armv7-apple-ios -mfloat-abi=softfp -### 2>&1 | FileCheck -check-prefix=ARMV7-SOFTFP %s
+
+// ARMV7-HARD: unsupported option '-mfloat-abi=hard' for target 'thumbv7'
+// ARMV7-SOFTFP-NOT: unsupported option

Original file line number	Diff line number	Diff line change
`@@ -582,6 +582,10 @@ StringRef tools::arm::getARMFloatABI(const Driver &D, const ArgList &Args,`
`582`	`582`	`FloatABI = "soft";`
`583`	`583`	`}`
`584`	`584`	`}`
	`585`	`+`
	`586`	`+ if (Triple.isOSDarwin() && FloatABI == "hard")`
	`587`	`+ D.Diag(diag::err_drv_unsupported_opt_for_target) << A->getAsString(Args)`
	`588`	`+ << Triple.getArchName();`
`585`	`589`	`}`
`586`	`590`
`587`	`591`	`// If unspecified, choose the default based on the platform.`