[TestMiBreak] Print a formatted string via printf in the test case.

Siva Chandra · Siva Chandra · commit f5941b8d081c · 2015-04-15T18:32:17.000Z
Summary: If the string is not formatted, these can happen when compiled with GCC: 1. If it is a null string "", then GCC completely removes the call to printf even with -O0. 2. If the string is a single character string, say "\n" for example, then GCC replaces the call to printf with a call to putchar. 3. If the string length is greater than 1, but is not formatted, then GCC replaces the call to printf with a call to puts. All the above will fail the test as we want a breakpoint on "printf" to hit. Test Plan: dotest.py -C gcc -p TestMiBreak Reviewers: chying, ki.stfu Reviewed By: ki.stfu Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D9025 llvm-svn: 235034
diff --git a/lldb/test/tools/lldb-mi/breakpoint/TestMiBreak.py b/lldb/test/tools/lldb-mi/breakpoint/TestMiBreak.py
@@ -13,7 +13,6 @@ class MiBreakTestCase(lldbmi_testcase.MiTestCaseBase):
     @lldbmi_test
     @expectedFailureWindows("llvm.org/pr22274: need a pexpect replacement for windows")
     @skipIfFreeBSD # llvm.org/pr22411: Failure presumably due to known thread races
-    @expectedFailureGcc #xfail to get buildbot green, test failed with gcc4.8.2
     def test_lldbmi_break_insert_function_pending(self):
         """Test that 'lldb-mi --interpreter' works for pending function breakpoints."""
 
@@ -38,7 +37,6 @@ def test_lldbmi_break_insert_function_pending(self):
     @lldbmi_test
     @expectedFailureWindows("llvm.org/pr22274: need a pexpect replacement for windows")
     @skipIfFreeBSD # llvm.org/pr22411: Failure presumably due to known thread races
-    @expectedFailureGcc #xfail to get buildbot green, test failed with gcc4.8.2
     def test_lldbmi_break_insert_function(self):
         """Test that 'lldb-mi --interpreter' works for function breakpoints."""
 
@@ -98,7 +96,6 @@ def test_lldbmi_break_insert_file_line_pending(self):
     @lldbmi_test
     @expectedFailureWindows("llvm.org/pr22274: need a pexpect replacement for windows")
     @skipIfFreeBSD # llvm.org/pr22411: Failure presumably due to known thread races
-    @expectedFailureGcc #xfail to get buildbot green, test failed with gcc4.8.2
     def test_lldbmi_break_insert_file_line(self):
         """Test that 'lldb-mi --interpreter' works for file:line breakpoints."""
 
diff --git a/lldb/test/tools/lldb-mi/breakpoint/main.cpp b/lldb/test/tools/lldb-mi/breakpoint/main.cpp
@@ -12,6 +12,6 @@
 int
 main(int argc, char const *argv[])
 {
-    printf("");
+    printf("Print a formatted string so that GCC does not optimize this printf call: %s\n", argv[0]);
     return 0; // BP_return
 }

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,6 @@`
`12`	`12`	`int`
`13`	`13`	`main(int argc, char const *argv[])`
`14`	`14`	`{`
`15`		`- printf("");`
	`15`	`+ printf("Print a formatted string so that GCC does not optimize this printf call: %s\n", argv[0]);`
`16`	`16`	`return 0; // BP_return`
`17`	`17`	`}`