This is an archive of the discontinued LLVM Phabricator instance.

When using "make VERBOSE=1", make sure compiler-rt is also build verbosely.
ClosedPublic

Authored by Jean-Daniel on Oct 18 2012, 5:41 AM.

Details

Reviewers
Jean-Daniel
Summary

When building clang+compiler-rt verbosely, the build commands of compiler-rt are not output in the terminal as expected.
This patch fixes the issue by forwarding the VERBOSE flag to the compiler-rt make.

Diff Detail

Event Timeline

Why not just do:
VERBOSE ?= $(VERBOSE)

Wondering why a new variable needs to be created here.

actually that doesn't make sense, why not just use $(VERBOSE) instead of $(RUNTIME_VERBOSE) in the make rule?

Jean-Daniel updated this revision to Unknown Object (????).Oct 27 2012, 12:19 AM

Because I erroneously though that simply using "make VERBOSE=" was enough to enable verbose mode.

Jean-Daniel accepted this revision.May 15 2014, 12:57 AM
Jean-Daniel added a reviewer: Jean-Daniel.
This revision is now accepted and ready to land.May 15 2014, 12:57 AM
Jean-Daniel closed this revision.May 15 2014, 1:11 AM