Page MenuHomePhabricator

[NVPTX] aligned byte-buffers for vector return types
ClosedPublic

Authored by jingyue on Oct 3 2014, 4:01 PM.

Details

Summary

Fixes PR21100 which is caused by inconsistency between the declared return type
and the expected return type at the call site. The new behavior is consistent
with nvcc and the NVPTXTargetLowering::getPrototype function.

Diff Detail

Event Timeline

jingyue updated this revision to Diff 14415.Oct 3 2014, 4:01 PM
jingyue retitled this revision from to [NVPTX] aligned byte-buffers for vector return types.
jingyue updated this object.
jingyue edited the test plan for this revision. (Show Details)
jingyue added a reviewer: jholewinski.
jingyue added subscribers: eliben, meheff, Unknown Object (MLST).
eliben added inline comments.Oct 3 2014, 4:08 PM
lib/Target/NVPTX/NVPTXISelLowering.cpp
1358–1363

Can you add a comment that explains why these types are handled?

test/CodeGen/NVPTX/vector-return.ll
2

The name of the test is very generic but you're just checking the alignment. Perhaps it would be better to either make the test name more specific, or alternatively check for more things in it?

4

Is there a significance to fastcc here? If yes, please add a comment :)

jingyue updated this revision to Diff 14418.Oct 3 2014, 6:04 PM

Thanks Eli!

Hi Justin,

How does this diff look to you?

Thanks,
Jingyue

jholewinski accepted this revision.Oct 24 2014, 1:06 PM
jholewinski edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Oct 24 2014, 1:06 PM
jingyue closed this revision.Oct 24 2014, 8:56 PM