Page MenuHomePhabricator

Assign SEH handler indices to __try blocks
ClosedPublic

Authored by whunt on Jul 18 2014, 3:15 PM.

Details

Reviewers
majnemer
Summary

Assigns indices to try blocks. These indices will used in constructing tables that the mscrt function except_handler3 reads during SEH.

Diff Detail

Event Timeline

whunt updated this revision to Diff 11674.Jul 18 2014, 3:15 PM
whunt retitled this revision from to Assign SEH handler indices to __try blocks.
whunt updated this object.
whunt edited the test plan for this revision. (Show Details)
whunt added a reviewer: majnemer.
whunt added a subscriber: Unknown Object (MLST).
majnemer accepted this revision.Jul 18 2014, 5:25 PM
majnemer edited edge metadata.

LGTM with the comments addressed.

include/clang/AST/Stmt.h
1895–1896

Can these be aligned with the fields above?

lib/Parse/ParseStmt.cpp
1990–2000

This doesn't look correctly formatted, can you run this through clang-format?

This revision is now accepted and ready to land.Jul 18 2014, 5:25 PM
whunt added a comment.Jul 18 2014, 5:32 PM

All comments addressed.

whunt closed this revision.Jul 18 2014, 5:54 PM