Page MenuHomePhabricator

lldb: deal with non-portable PTRACE-related constants
ClosedPublic

Authored by pawelo on Jun 10 2014, 12:45 PM.

Details

Reviewers
tfiala
Summary

These PTRACE-related enum values are not present everywhere; their presence is denoted by certain preprocessor definitions in sys/ptrace.h that we can check.

Diff Detail

Event Timeline

pawelo updated this revision to Diff 10295.Jun 10 2014, 12:45 PM
pawelo retitled this revision from to lldb: deal with non-portable PTRACE-related constants.
pawelo updated this object.
pawelo edited the test plan for this revision. (Show Details)
pawelo set the repository for this revision to rL LLVM.
pawelo added a subscriber: Unknown Object (MLST).
tfiala edited edge metadata.Jun 23 2014, 8:18 AM

Missed this one earlier this month. I'll have a look at this now.

tfiala accepted this revision.Jun 23 2014, 9:05 AM
tfiala edited edge metadata.

LGTM.

Although missing the support of ReadGPR() and ReadFPR() methods will reduce the functionality available - without these I think the inferior process will lose the ability to execute expressions within the process as full register state cannot be saved.

Note I'll be adding this and the previous cross-compile-related changes to the llgs branch as well - NativeProcessLinux.cpp in that branch operates similar to ProcessMonitor.cpp here.

This revision is now accepted and ready to land.Jun 23 2014, 9:05 AM
tfiala closed this revision.Jun 23 2014, 9:07 AM

svn commit
Sending source/Plugins/Process/Linux/ProcessMonitor.cpp
Transmitting file data .
Committed revision 211503.