Skip to content

Commit 85b4cd4

Browse files
committedNov 18, 2014
docs: Fix a couple of typo-ish errors in WritingAnLLVMPass
- Make CallGraphSCCPass's paragraph about doFinalization refer to runOnSCC instead of runOnFunction, since that's what it's about. - Fix a reference in the FunctionPass paragraph. llvm-svn: 222222
1 parent 9211ec4 commit 85b4cd4

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed
 

‎llvm/docs/WritingAnLLVMPass.rst

+3-4
Original file line numberDiff line numberDiff line change
@@ -434,9 +434,8 @@ The ``doFinalization(CallGraph &)`` method
434434
virtual bool doFinalization(CallGraph &CG);
435435

436436
The ``doFinalization`` method is an infrequently used method that is called
437-
when the pass framework has finished calling :ref:`runOnFunction
438-
<writing-an-llvm-pass-runOnFunction>` for every function in the program being
439-
compiled.
437+
when the pass framework has finished calling :ref:`runOnSCC
438+
<writing-an-llvm-pass-runOnSCC>` for every SCC in the program being compiled.
440439

441440
.. _writing-an-llvm-pass-FunctionPass:
442441

@@ -456,7 +455,7 @@ To be explicit, ``FunctionPass`` subclasses are not allowed to:
456455
#. Inspect or modify a ``Function`` other than the one currently being processed.
457456
#. Add or remove ``Function``\ s from the current ``Module``.
458457
#. Add or remove global variables from the current ``Module``.
459-
#. Maintain state across invocations of:ref:`runOnFunction
458+
#. Maintain state across invocations of :ref:`runOnFunction
460459
<writing-an-llvm-pass-runOnFunction>` (including global data).
461460

462461
Implementing a ``FunctionPass`` is usually straightforward (See the :ref:`Hello

0 commit comments

Comments
 (0)
Please sign in to comment.