MS ABI: Eliminate Duplicate Strings

Press ? to show keyboard shortcuts.
Committed
majnemerMar 24 2014, 2:43 PM
Parents
rL204674: [MS-ABI] Drop Special Layout in 64-bit mode.
Branches
Unknown
Tags
Unknown
Description

MS ABI: Eliminate Duplicate Strings

COFF doesn't have mergeable sections so LLVM/clang's normal tactics for
string deduplication will not have any effect.

To remedy this we place each string inside it's own section and mark
the section as IMAGE_COMDAT_SELECT_ANY. However, we can only do this if the
string has an external name that we can generate from it's contents.

To be compatible with MSVC, we must use their scheme. Otherwise identical
strings in translation units from clang may not be deduplicated with
translation units in MSVC.

This fixes PR18248.

N.B. We will not attempt to do anything with a string literal which is not of
type 'char' or 'wchar_t' because their compiler does not support unicode
string literals as of this date. Further, we avoid doing this if
either -fwritable-strings or -fsanitize=address are present.

This reverts commit r204596.

rL204675

cfe/trunk/include/clang/AST/Mangle.h

Loading...

cfe/trunk/lib/AST/ItaniumMangle.cpp

Loading...

cfe/trunk/lib/AST/MicrosoftMangle.cpp

Loading...

cfe/trunk/lib/CodeGen/CodeGenModule.cpp

Loading...

cfe/trunk/lib/CodeGen/CodeGenModule.h

Loading...

cfe/trunk/test/CodeGen/c-strings.c

Loading...

cfe/trunk/test/CodeGen/string-literal-short-wstring.c

Loading...

cfe/trunk/test/CodeGen/wchar-const.c

Loading...

cfe/trunk/test/CodeGenCXX/mangle-ms-string-literals.cpp

Loading...

Add Comment