[PowerPC] Initial support for the VSX instruction set

Press ? to show keyboard shortcuts.
Committed
hfinkelMar 13 2014, 12:58 AM
Parents
rL203767: [TableGen] Optionally forbid overlap between named and positional operands
Branches
Unknown
Tags
Unknown
Description

[PowerPC] Initial support for the VSX instruction set

VSX is an ISA extension supported on the POWER7 and later cores that enhances
floating-point vector and scalar capabilities. Among other things, this adds
<2 x double> support and generally helps to reduce register pressure.

The interesting part of this ISA feature is the register configuration: there
are 64 new 128-bit vector registers, the 32 of which are super-registers of the
existing 32 scalar floating-point registers, and the second 32 of which overlap
with the 32 Altivec vector registers. This makes things like vector insertion
and extraction tricky: this can be free but only if we force a restriction to
the right register subclass when needed. A new "minipass" PPCVSXCopy takes care
of this (although it could do a more-optimal job of it; see the comment about
unnecessary copies below).

Please note that, currently, VSX is not enabled by default when targeting
anything because it is not yet ready for that. The assembler and disassembler
are fully implemented and tested. However:

  • CodeGen support causes miscompiles; test-suite runtime failures: MultiSource/Benchmarks/FreeBench/distray/distray MultiSource/Benchmarks/McCat/08-main/main MultiSource/Benchmarks/Olden/voronoi/voronoi MultiSource/Benchmarks/mafft/pairlocalalign MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4 SingleSource/Benchmarks/CoyoteBench/almabench SingleSource/Benchmarks/Misc/matmul_f64_4x4
  • The lowering currently falls back to using Altivec instructions far more than it should. Worse, there are some things that are scalarized through the stack that shouldn't be.
  • A lot of unnecessary copies make it past the optimizers, and this needs to be fixed.
  • Many more regression tests are needed.

Normally, I'd fix these things prior to committing, but there are some
students and other contributors who would like to work this, and so it makes
sense to move this development process upstream where it can be subject to the
regular code-review procedures.

Changes (22)

HistoryBrowseChangePath
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/Disassembler/PPCDisassembler.cpp
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/InstPrinter/PPCInstPrinter.cpp
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/InstPrinter/PPCInstPrinter.h
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPC.h
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPC.td
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPCISelDAGToDAG.cpp
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPCInstrFormats.td
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPCInstrInfo.cpp
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPCInstrInfo.td
HistoryBrowseAddedllvm/trunk/lib/Target/PowerPC/PPCInstrVSX.td
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.cpp
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.td
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPCSubtarget.cpp
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPCSubtarget.h
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPCTargetMachine.cpp
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPCTargetTransformInfo.cpp
HistoryBrowseAddedllvm/trunk/test/CodeGen/PowerPC/vsx.ll
HistoryBrowseAddedllvm/trunk/test/MC/Disassembler/PowerPC/vsx.txt
HistoryBrowseAddedllvm/trunk/test/MC/PowerPC/vsx.s

rL203768

llvm/trunk/lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp

Loading...

llvm/trunk/lib/Target/PowerPC/Disassembler/PPCDisassembler.cpp

Loading...

llvm/trunk/lib/Target/PowerPC/InstPrinter/PPCInstPrinter.cpp

Loading...

llvm/trunk/lib/Target/PowerPC/InstPrinter/PPCInstPrinter.h

Loading...

llvm/trunk/lib/Target/PowerPC/PPC.h

Loading...

llvm/trunk/lib/Target/PowerPC/PPC.td

Loading...

llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp

Loading...

llvm/trunk/lib/Target/PowerPC/PPCISelDAGToDAG.cpp

Loading...

llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp

Loading...

llvm/trunk/lib/Target/PowerPC/PPCInstrFormats.td

Loading...

llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.cpp

Loading...

llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.td

Loading...

llvm/trunk/lib/Target/PowerPC/PPCInstrVSX.td

Loading...

llvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.cpp

Loading...

llvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.td

Loading...

llvm/trunk/lib/Target/PowerPC/PPCSubtarget.cpp

Loading...

llvm/trunk/lib/Target/PowerPC/PPCSubtarget.h

Loading...

llvm/trunk/lib/Target/PowerPC/PPCTargetMachine.cpp

Loading...

llvm/trunk/lib/Target/PowerPC/PPCTargetTransformInfo.cpp

Loading...

llvm/trunk/test/CodeGen/PowerPC/vsx.ll

Loading...

llvm/trunk/test/MC/Disassembler/PowerPC/vsx.txt

Loading...

llvm/trunk/test/MC/PowerPC/vsx.s

Loading...

Add Comment