-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[mips] Implement NaCl sandboxing of loads, stores and SP changes:
* Add masking instructions before loads and stores (in MC layer). * Add masking instructions after SP changes (in MC layer). * Forbid loads, stores and SP changes in delay slots (in MI layer). Differential Revision: http://llvm-reviews.chandlerc.com/D2904 llvm-svn: 203484
- Loading branch information
Sasa Stankovic
authored and
Sasa Stankovic
committed
Mar 10, 2014
1 parent
e78ae05
commit 5fddf61
Showing
5 changed files
with
385 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
; RUN: llc -filetype=asm -mtriple=mipsel-none-linux -relocation-model=static \ | ||
; RUN: -O3 < %s | FileCheck %s | ||
|
||
; RUN: llc -filetype=asm -mtriple=mipsel-none-nacl -relocation-model=static \ | ||
; RUN: -O3 < %s | FileCheck %s -check-prefix=CHECK-NACL | ||
|
||
@x = global i32 0, align 4 | ||
declare void @f1(i32) | ||
declare void @f2() | ||
|
||
|
||
define void @test1() { | ||
%1 = load i32* @x, align 4 | ||
call void @f1(i32 %1) | ||
ret void | ||
|
||
|
||
; CHECK-LABEL: test1 | ||
|
||
; We first make sure that for non-NaCl targets branch-delay slot contains | ||
; dangerous instructions. | ||
|
||
; Check that branch-delay slot is used to load argument from x before function | ||
; call. | ||
|
||
; CHECK: jal | ||
; CHECK-NEXT: lw $4, %lo(x)(${{[0-9]+}}) | ||
|
||
; Check that branch-delay slot is used for adjusting sp before return. | ||
|
||
; CHECK: jr $ra | ||
; CHECK-NEXT: addiu $sp, $sp, {{[0-9]+}} | ||
|
||
|
||
; For NaCl, check that branch-delay slot doesn't contain dangerous instructions. | ||
|
||
; CHECK-NACL: jal | ||
; CHECK-NACL-NEXT: nop | ||
|
||
; CHECK-NACL: jr $ra | ||
; CHECK-NACL-NEXT: nop | ||
} | ||
|
||
|
||
define void @test2() { | ||
store i32 1, i32* @x, align 4 | ||
tail call void @f2() | ||
ret void | ||
|
||
|
||
; CHECK-LABEL: test2 | ||
|
||
; Check that branch-delay slot is used for storing to x before function call. | ||
|
||
; CHECK: jal | ||
; CHECK-NEXT: sw ${{[0-9]+}}, %lo(x)(${{[0-9]+}}) | ||
|
||
; Check that branch-delay slot is used for adjusting sp before return. | ||
|
||
; CHECK: jr $ra | ||
; CHECK-NEXT: addiu $sp, $sp, {{[0-9]+}} | ||
|
||
|
||
; For NaCl, check that branch-delay slot doesn't contain dangerous instructions. | ||
|
||
; CHECK-NACL: jal | ||
; CHECK-NACL-NEXT: nop | ||
|
||
; CHECK-NACL: jr $ra | ||
; CHECK-NACL-NEXT: nop | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters