This is an archive of the discontinued LLVM Phabricator instance.

Fix BreakpointLocationCollection::ShouldStop to handle breakpoint removal
ClosedPublic

Authored by tberghammer on May 20 2015, 10:37 AM.

Details

Summary

Fix BreakpointLocationCollection::ShouldStop to handle breakpoint removal

ShouldStop will call the callback of the breakpoint what removes the breakpoint in some case (e.g.: dynamic loader entry breakpoint). This behaviour caused segfault or missing of stop in some case with the previous implementation.

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer retitled this revision from to Fix BreakpointLocationCollection::ShouldStop to handle breakpoint removal.
tberghammer updated this object.
tberghammer edited the test plan for this revision. (Show Details)
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.May 26 2015, 2:56 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.May 26 2015, 2:56 PM
This revision was automatically updated to reflect the committed changes.