Page MenuHomePhabricator

Changing CMake variable prefix to LIBOMP.
ClosedPublic

Authored by jlpeyton on May 18 2015, 11:14 AM.

Details

Summary

Cached CMake variables need to have a prefix so they don't collide with other projects. This change (a lot of simple changes) simply prefixes cached variables with LIBOMP_ and sets all of these variables to UPPERCASE which is convention. e.g., os => LIBOMP_OS, ompt_support => LIBOMP_OMPT_SUPPORT.

Diff Detail

Repository
rL LLVM

Event Timeline

jlpeyton updated this revision to Diff 25986.May 18 2015, 11:14 AM
jlpeyton retitled this revision from to Changing CMake variable prefix to LIBOMP..
jlpeyton updated this object.
jlpeyton edited the test plan for this revision. (Show Details)
jlpeyton added reviewers: hfinkel, chandlerc.
jlpeyton set the repository for this revision to rL LLVM.
jlpeyton added subscribers: Unknown Object (MLST), Unknown Object (MLST).
hfinkel accepted this revision.May 18 2015, 12:35 PM
hfinkel edited edge metadata.

Without meaning to imply that we won't need to fine-tune some of the other names based on future feedback from Chandler and others. This LGTM.

This revision is now accepted and ready to land.May 18 2015, 12:35 PM
This revision was automatically updated to reflect the committed changes.