This is an archive of the discontinued LLVM Phabricator instance.

Fix finding libunwind when only using LIBCXXABI_USE_LLVM_UNWINDER=ON
ClosedPublic

Authored by wjywbs on May 9 2015, 1:08 PM.

Details

Reviewers
asl
Summary

LIBCXXABI_LIBUNWIND_INCLUDES is already set before calling find_path, and find_path will not update it. So cmake will throw error "include_directories given empty-string as include directory". Use other variable name for the include path and do not find the default libunwind.h in the system path.

Diff Detail

Repository
rL LLVM

Event Timeline

wjywbs updated this revision to Diff 25420.May 9 2015, 1:08 PM
wjywbs retitled this revision from to Fix finding libunwind when only using LIBCXXABI_USE_LLVM_UNWINDER=ON.
wjywbs updated this object.
wjywbs edited the test plan for this revision. (Show Details)
wjywbs added a reviewer: asl.
wjywbs set the repository for this revision to rL LLVM.
wjywbs added subscribers: wjywbs, Unknown Object (MLST).
asl accepted this revision.May 9 2015, 1:48 PM
asl edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 9 2015, 1:48 PM
wjywbs added a comment.May 9 2015, 1:49 PM

Could you please commit for me because I am not a committer? Thanks.

asl closed this revision.May 9 2015, 2:04 PM