This is an archive of the discontinued LLVM Phabricator instance.

[OPENMP] Fixed codegen for 'reduction' clause
ClosedPublic

Authored by ABataev on May 5 2015, 10:02 PM.

Details

Summary

Fixed codegen for reduction operations min, max, && and ||. Codegen for them is quite similar and I was confused by this similarity.
Also added a call to kmpc_end_reduce() in atomic part of reduction codegen (call to kmpc_end_reduce_nowait() is not required).

Diff Detail

Repository
rL LLVM

Event Timeline

ABataev updated this revision to Diff 25006.May 5 2015, 10:02 PM
ABataev retitled this revision from to [OPENMP] Fixed codegen for 'reduction' clause.
ABataev updated this object.
ABataev edited the test plan for this revision. (Show Details)
ABataev added reviewers: rjmccall, hfinkel.
ABataev added subscribers: fraggamuffin, ejstotzer, Unknown Object (MLST).
rjmccall edited edge metadata.May 6 2015, 10:09 AM

LGTM.

lib/CodeGen/CGOpenMPRuntime.cpp
2257 ↗(On Diff #25006)

"it's" => "its"

This revision was automatically updated to reflect the committed changes.