This is an archive of the discontinued LLVM Phabricator instance.

Fix ClangUserExpression::Evaluate return code in case of eExpressionParseError
ClosedPublic

Authored by ki.stfu on May 5 2015, 10:48 AM.

Reviewers

Commits

Summary

This patch fixes retvalue of ClangUserExpression::Evaluate in case of eExpressionParseError error

ki.stfu retitled this revision from to Fix ClangUserExpression::Evaluate return code in case of eExpressionParseError.

ki.stfu updated this object.

ki.stfu edited the test plan for this revision. (Show Details)

ki.stfu added subscribers: jingham, spyffe, clayborg, Unknown Object (MLST).

Looks good.

This revision is now accepted and ready to land.May 5 2015, 10:57 AM

Path

Size

source/

Expression/

5 lines

Show First 20 Lines • Show All 1,060 Lines • ▼ Show 20 Lines	ClangUserExpression::Evaluate (ExecutionContext &exe_ctx,
}		}

if (!user_expression_sp->Parse (error_stream,		if (!user_expression_sp->Parse (error_stream,
exe_ctx,		exe_ctx,
execution_policy,		execution_policy,
keep_expression_in_memory,		keep_expression_in_memory,
generate_debug_info))		generate_debug_info))
{		{
		execution_results = lldb::eExpressionParseError;
if (error_stream.GetString().empty())		if (error_stream.GetString().empty())
error.SetExpressionError (lldb::eExpressionParseError, "expression failed to parse, unknown error");		error.SetExpressionError (execution_results, "expression failed to parse, unknown error");
else		else
error.SetExpressionError (lldb::eExpressionParseError, error_stream.GetString().c_str());		error.SetExpressionError (execution_results, error_stream.GetString().c_str());
}		}
else		else
{		{
lldb::ClangExpressionVariableSP expr_result;		lldb::ClangExpressionVariableSP expr_result;

if (execution_policy == eExecutionPolicyNever &&		if (execution_policy == eExecutionPolicyNever &&
!user_expression_sp->CanInterpret())		!user_expression_sp->CanInterpret())
{		{
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines