This is an archive of the discontinued LLVM Phabricator instance.

Differential D9438

Move unit test into anonymous namespace as per convention.
ClosedPublic

Authored by dougk on May 1 2015, 10:46 AM.

Details

Reviewers
joerg
Summary

Current placement seems to have been inadvertent.

Diff Detail

Event Timeline

dougk updated this revision to Diff 24819.May 1 2015, 10:46 AM
dougk retitled this revision from to Move unit test into anonymous namespace as per convention..
dougk updated this object.
dougk edited the test plan for this revision. (Show Details)
dougk added a reviewer: joerg.
dougk added a subscriber: Unknown Object (MLST).
joerg accepted this revision.May 1 2015, 11:04 AM
joerg edited edge metadata.

Assuming it still compiles, I'm fine with it.

This revision is now accepted and ready to land.May 1 2015, 11:04 AM
dougk closed this revision.May 1 2015, 11:56 AM

committed

Revision Contents

PathSize
unittests/
ADT/
3 lines

Diff 24819

unittests/ADT/TripleTest.cpp

Show First 20 Lines • Show All 688 Lines • ▼ Show 20 LinesTEST(TripleTest, getARMCPUForArch) {
EXPECT_STREQ("cortex-a8", Triple.getARMCPUForArch()); EXPECT_STREQ("cortex-a8", Triple.getARMCPUForArch());
EXPECT_STREQ("swift", Triple.getARMCPUForArch("armv7s")); EXPECT_STREQ("swift", Triple.getARMCPUForArch("armv7s"));
} }
{ {
llvm::Triple Triple("arm--nacl"); llvm::Triple Triple("arm--nacl");
EXPECT_STREQ("cortex-a8", Triple.getARMCPUForArch("arm")); EXPECT_STREQ("cortex-a8", Triple.getARMCPUForArch("arm"));
} }
} }
}
TEST(TripleTest, NormalizeARM) { TEST(TripleTest, NormalizeARM) {
EXPECT_EQ("armv6--netbsd-eabi", Triple::normalize("armv6-netbsd-eabi")); EXPECT_EQ("armv6--netbsd-eabi", Triple::normalize("armv6-netbsd-eabi"));
EXPECT_EQ("armv7--netbsd-eabi", Triple::normalize("armv7-netbsd-eabi")); EXPECT_EQ("armv7--netbsd-eabi", Triple::normalize("armv7-netbsd-eabi"));
EXPECT_EQ("armv6eb--netbsd-eabi", Triple::normalize("armv6eb-netbsd-eabi")); EXPECT_EQ("armv6eb--netbsd-eabi", Triple::normalize("armv6eb-netbsd-eabi"));
EXPECT_EQ("armv7eb--netbsd-eabi", Triple::normalize("armv7eb-netbsd-eabi")); EXPECT_EQ("armv7eb--netbsd-eabi", Triple::normalize("armv7eb-netbsd-eabi"));
EXPECT_EQ("armv6--netbsd-eabihf", Triple::normalize("armv6-netbsd-eabihf")); EXPECT_EQ("armv6--netbsd-eabihf", Triple::normalize("armv6-netbsd-eabihf"));
EXPECT_EQ("armv7--netbsd-eabihf", Triple::normalize("armv7-netbsd-eabihf")); EXPECT_EQ("armv7--netbsd-eabihf", Triple::normalize("armv7-netbsd-eabihf"));
EXPECT_EQ("armv6eb--netbsd-eabihf", Triple::normalize("armv6eb-netbsd-eabihf")); EXPECT_EQ("armv6eb--netbsd-eabihf", Triple::normalize("armv6eb-netbsd-eabihf"));
EXPECT_EQ("armv7eb--netbsd-eabihf", Triple::normalize("armv7eb-netbsd-eabihf")); EXPECT_EQ("armv7eb--netbsd-eabihf", Triple::normalize("armv7eb-netbsd-eabihf"));
Triple T; Triple T;
T = Triple("armv6--netbsd-eabi"); T = Triple("armv6--netbsd-eabi");
EXPECT_EQ(Triple::arm, T.getArch()); EXPECT_EQ(Triple::arm, T.getArch());
T = Triple("armv6eb--netbsd-eabi"); T = Triple("armv6eb--netbsd-eabi");
EXPECT_EQ(Triple::armeb, T.getArch()); EXPECT_EQ(Triple::armeb, T.getArch());
} }
} // end anonymous namespace