This is an archive of the discontinued LLVM Phabricator instance.

Differential D9412

Proposed Resolution for LWG Issue #2454: Add raw_storage_iterator::base() member
ClosedPublic

Authored by mclow.lists on Apr 30 2015, 11:48 AM.

Details

Reviewers
EricWF
Summary

http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-active.html#2454

Diff Detail

Event Timeline

mclow.lists updated this revision to Diff 24760.Apr 30 2015, 11:48 AM
mclow.lists retitled this revision from to Proposed Resolution for LWG Issue #2454: Add raw_storage_iterator::base() member.
mclow.lists updated this object.
mclow.lists edited the test plan for this revision. (Show Details)
mclow.lists added a reviewer: EricWF.
mclow.lists added a subscriber: Unknown Object (MLST).
EricWF accepted this revision.Apr 30 2015, 6:17 PM
EricWF edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Apr 30 2015, 6:17 PM
mclow.lists closed this revision.May 18 2015, 11:30 AM

Committed as r 236948

Revision Contents

PathSize
include/
3 lines
test/
std/
utilities/
memory/
storage.iterator/
6 lines

Diff 24760

include/memory

Context not available.
_LIBCPP_INLINE_VISIBILITY raw_storage_iterator& operator++() {++__x_; return *this;} _LIBCPP_INLINE_VISIBILITY raw_storage_iterator& operator++() {++__x_; return *this;}
_LIBCPP_INLINE_VISIBILITY raw_storage_iterator operator++(int) _LIBCPP_INLINE_VISIBILITY raw_storage_iterator operator++(int)
{raw_storage_iterator __t(*this); ++__x_; return __t;} {raw_storage_iterator __t(*this); ++__x_; return __t;}
#if _LIBCPP_STD_VER >= 14
_LIBCPP_INLINE_VISIBILITY _OutputIterator base() const { return __x_; }
#endif
}; };
template <class _Tp> template <class _Tp>
Context not available.

test/std/utilities/memory/storage.iterator/raw_storag_iterator.pass.cpp

Context not available.
Storage buffer; Storage buffer;
std::raw_storage_iterator<A*, A> it((A*)&buffer); std::raw_storage_iterator<A*, A> it((A*)&buffer);
assert(A_constructed == 0); assert(A_constructed == 0);
#if __cplusplus >= 201402L
assert(it.base() == (A*)&buffer);
#endif
for (int i = 0; i < 3; ++i) for (int i = 0; i < 3; ++i)
{ {
*it++ = A(i+1); *it++ = A(i+1);
A* ap = (A*)&buffer + i; A* ap = (A*)&buffer + i;
assert(*ap == i+1); assert(*ap == i+1);
assert(A_constructed == i+1); assert(A_constructed == i+1);
#if __cplusplus >= 201402L
assert(it.base() == ap + 1); // next place to write
#endif
} }
} }
Context not available.