This is an archive of the discontinued LLVM Phabricator instance.

llvm-ar shouldn't need targets
AbandonedPublic

Authored by beanz on Apr 29 2015, 5:08 PM.

Details

Summary

There isn't any code in llvm-ar that actually uses targets, but it links them because it calls a few InitializeAll* functions. If we remove those calls, we can remove the dependency on the targets, which makes building llvm-ar a lot faster.

Diff Detail

Event Timeline

beanz updated this revision to Diff 24671.Apr 29 2015, 5:08 PM
beanz retitled this revision from to llvm-ar shouldn't need targets.
beanz updated this object.
beanz edited the test plan for this revision. (Show Details)
beanz added reviewers: rafael, chandlerc.
beanz added a subscriber: Unknown Object (MLST).
rafael edited edge metadata.Apr 30 2015, 12:38 PM

It needs to be able to parse assembly in order to populate the symbol
table. No tests fail with this? I will add one if so.

We already have Object/X86/archive-ir-asm.ll. Was it passing for you?

beanz abandoned this revision.Apr 30 2015, 1:02 PM

Ugh... I had completely overlooked generating symbol tables for assembly files. The layering oddness here kinda hurts my head and feels a bit off, but I get it.

I'll abandon this revision as my brain being out to lunch.

Thanks,
-Chris