This is an archive of the discontinued LLVM Phabricator instance.

[ASan/Win] Increase the size of the PC array for coverage on Windows
ClosedPublic

Authored by timurrrr on Apr 24 2015, 10:21 AM.

Reviewers

kcc
samsonov

Summary

The current value is not sufficient to even start Chrome.
The new value seems to be sufficient.

timurrrr retitled this revision from to [ASan/Win] Increase the size of the PC array for coverage on Windows.

timurrrr updated this object.

timurrrr edited the test plan for this revision. (Show Details)

timurrrr added reviewers: samsonov, kcc.

timurrrr added a subscriber: Unknown Object (MLST).

LGTM.

samsonov edited edge metadata.

This revision is now accepted and ready to land.Apr 24 2015, 11:11 AM

r235779, thanks!

Path

Size

lib/

sanitizer_common/

5 lines

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines	public:
uptr size();		uptr size();

private:		private:
void DirectOpen();		void DirectOpen();
void UpdateModuleNameVec(uptr caller_pc, uptr range_beg, uptr range_end);		void UpdateModuleNameVec(uptr caller_pc, uptr range_beg, uptr range_end);

// Maximal size pc array may ever grow.		// Maximal size pc array may ever grow.
// We MmapNoReserve this space to ensure that the array is contiguous.		// We MmapNoReserve this space to ensure that the array is contiguous.
static const uptr kPcArrayMaxSize =		static const uptr kPcArrayMaxSize = FIRST_32_SECOND_64(
FIRST_32_SECOND_64(1 << (SANITIZER_ANDROID ? 24 : 26), 1 << 27);		1 << (SANITIZER_ANDROID ? 24 : (SANITIZER_WINDOWS ? 27 : 26)),
		1 << 27);
// The amount file mapping for the pc array is grown by.		// The amount file mapping for the pc array is grown by.
static const uptr kPcArrayMmapSize = 64 * 1024;		static const uptr kPcArrayMmapSize = 64 * 1024;

// pc_array is allocated with MmapNoReserveOrDie and so it uses only as		// pc_array is allocated with MmapNoReserveOrDie and so it uses only as
// much RAM as it really needs.		// much RAM as it really needs.
uptr *pc_array;		uptr *pc_array;
// Index of the first available pc_array slot.		// Index of the first available pc_array slot.
atomic_uintptr_t pc_array_index;		atomic_uintptr_t pc_array_index;
▲ Show 20 Lines • Show All 811 Lines • Show Last 20 Lines