This is an archive of the discontinued LLVM Phabricator instance.

Correct extractelement constant folding
ClosedPublic

Authored by chfast on Apr 23 2015, 8:08 AM.

Details

Summary

Constant folding of extractelement with out-of-bound index produces undef also for indexes bigger than 64bit (instead of crash assert failure as before)

Diff Detail

Event Timeline

chfast updated this revision to Diff 24305.Apr 23 2015, 8:08 AM
chfast retitled this revision from to Correct extractelement constant folding.
chfast updated this object.
chfast edited the test plan for this revision. (Show Details)
chfast added a reviewer: majnemer.
chfast added a subscriber: Unknown Object (MLST).
majnemer accepted this revision.Apr 23 2015, 9:22 AM
majnemer edited edge metadata.

LGTM

This revision is now accepted and ready to land.Apr 23 2015, 9:22 AM

Side questions: shouldn’t insertelement constant folding produce undefs in case of wrong index (as reference states)?

Yes, it seems like it should produce undef.

chfast closed this revision.Apr 24 2015, 12:45 AM