Page MenuHomePhabricator

Uses the target platform to determine the platform context.
ClosedPublic

Authored by flackr on Apr 16 2015, 2:01 AM.

Details

Summary

Uses the target platform to determine the platform context to use. This fixes an early failure in some tests when running on a different remote target.

Diff Detail

Repository
rL LLVM

Event Timeline

flackr updated this revision to Diff 23829.Apr 16 2015, 2:01 AM
flackr retitled this revision from to Uses the target platform to determine the platform context..
flackr updated this object.
flackr edited the test plan for this revision. (Show Details)
flackr added reviewers: tberghammer, clayborg.
flackr set the repository for this revision to rL LLVM.
flackr edited the test plan for this revision. (Show Details)
flackr added a subscriber: Unknown Object (MLST).
tberghammer added inline comments.Apr 16 2015, 2:33 AM
test/lldbtest.py
698 ↗(On Diff #23829)

Please fix (or remove) the comment

863 ↗(On Diff #23829)

Please consider unifying the check for Linux and FreeBSD.

flackr updated this revision to Diff 23859.Apr 16 2015, 7:57 AM

Remove platformIsLinux rather than start creating platformIsX for each platform string getPlatform can return.

test/lldbtest.py
698 ↗(On Diff #23829)

Removed.

863 ↗(On Diff #23829)

Removed platformIsLinux().

tberghammer accepted this revision.Apr 16 2015, 8:17 AM
tberghammer edited edge metadata.

LGTM

This revision is now accepted and ready to land.Apr 16 2015, 8:17 AM
clayborg accepted this revision.Apr 16 2015, 12:52 PM
clayborg edited edge metadata.
This revision was automatically updated to reflect the committed changes.