Make ubsan respect log_path

[hfinkel]

Summary

As with the other sanitizers, it is desirable to allow ubsan's output to be redirected to somewhere other than stderr (and into per-process log files).

[samsonov]

test/ubsan/TestCases/Misc/log-path_test.cc

2

Please try to cover just the basic functionality in this test case instead of copying the whole test case from ASan test suite. Ideally, we should create a shared test case for all sanitizers under compiler-rt/test/sanitizer_common, but that would require triggering a sanitizer-specific report somehow.

[hfinkel]

Removed testing of invalid paths; that is common code that is covered already by the asan test.

[hfinkel]

test/ubsan/TestCases/Misc/log-path_test.cc

2

Sure; I've removed the tests for the invalid paths because that's common code covered by the asan test. I've only left the places where ubsan does something relevant.

[samsonov]

LGTM

[hfinkel]

r235277, thanks!

lib/ubsan/ubsan_init.cc

 
 static void CommonInit() {
   InitializeSuppressions();
 }
 
 static void CommonStandaloneInit() {
   SanitizerToolName = "UndefinedBehaviorSanitizer";
   InitializeFlags();
+  __sanitizer_set_report_path(common_flags()->log_path);
   InitializeCoverage(common_flags()->coverage, common_flags()->coverage_dir);
   CommonInit();
   ubsan_mode = UBSAN_MODE_STANDALONE;
 }
 
 void __ubsan::InitAsStandalone() {
   if (SANITIZER_CAN_USE_PREINIT_ARRAY) {
     CHECK_EQ(UBSAN_MODE_UNKNOWN, ubsan_mode);

test/ubsan/TestCases/Misc/log-path_test.cc

+// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
+// XFAIL: android
+
+// RUN: %clangxx -fsanitize=undefined %s -O1 -o %t
+
+// Regular run.
+// RUN: %run %t -4 2> %t.out
+// RUN: FileCheck %s --check-prefix=CHECK-ERROR < %t.out
+
+// Good log_path.
+// RUN: rm -f %t.log.*
+// RUN: env UBSAN_OPTIONS=log_path=%t.log %run %t -4 2> %t.out
+// RUN: FileCheck %s --check-prefix=CHECK-ERROR < %t.log.*
+
+// Run w/o errors should not produce any log.
+// RUN: rm -f %t.log.*
+// RUN: env UBSAN_OPTIONS=log_path=%t.log  %run %t 4
+// RUN: not cat %t.log.*
+
+// FIXME: log_path is not supported on Windows yet.
+// XFAIL: win32
+
+#include <stdio.h>
+#include <stdlib.h>
+int main(int argc, char *argv[]) {
+  double a = atof(argv[1]);
+  unsigned int ai = (unsigned int) a;
+  printf("%f %u\n", a, ai);
+  return 0;
+}
+
+// CHECK-ERROR: runtime error: value -4 is outside the range of representable values of type 'unsigned int'
+