Details
- Reviewers
jlpeyton
Diff Detail
Event Timeline
runtime/src/kmp.h | ||
---|---|---|
3071–3075 | No problem, will do | |
runtime/src/kmp_gsupport.c | ||
343 | While I'm ok with this change as well, this is a bit more tricky: __kmp_GOMP_fork_call is used inside macros (line #832 for example). While at it we could also change the new __kmp_GOMP_serialized_parallel (line #389) |
runtime/src/kmp_gsupport.c | ||
---|---|---|
343 | OK, let's then remain this function as is and change only __kmp_fork_call() above. Thank you. |
I accepted the revision, which now lets you close the revision. To do this you scroll to the bottom of the Phabricator page where it gives a list of Actions you can perform and choose Close Revision.
It seems to be reasonable to put this additional argument under #if OMPT_SUPPORT macro as well.