Fix check for options in "command alias"

[ted]

Summary

"command alias" can add invalid options to the command. "command alias start process launch -s" will add an extra argument, "<no-argument>" to the alias, so it runs "process launch -s <no-argument>", which launches the process with args that include "<no-argument>".

This patch changes the text compare of the variable value with "<OptionParser::eNoArgument>" to a compare of variable value_type with OptionParser::eNoArgument. It also moves the previous test inside the if, so it won't add a trailing space if there is no argument.

[clayborg]

Looks good.

lldb/trunk/source/Interpreter/CommandInterpreter.cpp

if (alias_cmd_obj)
                 int value_type = value_pair.first;
                 std::string option = option_pair.first;
                 std::string value = value_pair.second;
                 if (option.compare ("<argument>") == 0)
                     result_str.Printf (" %s", value.c_str());
                 else
                 {
                     result_str.Printf (" %s", option.c_str());
+                    if (value_type != OptionParser::eNoArgument)
+                    {
                         if (value_type != OptionParser::eOptionalArgument)
                             result_str.Printf (" ");
-                    if (value.compare ("<OptionParser::eNoArgument>") != 0)
-                    {
                         int index = GetOptionArgumentPosition (value.c_str());
                         if (index == 0)
                             result_str.Printf ("%s", value.c_str());
                         else if (static_cast<size_t>(index) >= cmd_args.GetArgumentCount())
                         {
                             
                             result.AppendErrorWithFormat
                             ("Not enough arguments provided; you need at least %d arguments to use this alias.\n",