Ignore IOError from missing child.log.

[chaoren]

Summary

TestMiCliSupport (among other TestMi*) fails on Linux with

IOError: [Errno 2] No such file or directory: 'child.log'

[ki.stfu]

test/tools/lldb-mi/lldbmi_testcase.py

28–31 ↗

(On Diff #23279)

I'd prefer to not use exceptions where it's not needed. Can we change it to the following?

import os.path
if os.path.exists(self.mylog):
    print open(self.mylog, "r").read()

[chaoren]

test/tools/lldb-mi/lldbmi_testcase.py

28–31 ↗

(On Diff #23279)

I thought EAFP is the preferred way to do things in python?

http://en.wikibooks.org/wiki/Python_Programming/Idioms#Principles

It's also possible for child.log to get removed (by another Mi test perhaps?) between the check and the read.

[ki.stfu]

lgtm

test/tools/lldb-mi/lldbmi_testcase.py

28–31 ↗

(On Diff #23279)

RE: I thought EAFP is the preferred way to do things in python?

ok.

RE: It's also possible for child.log to get removed (by another Mi test perhaps?) between the check and the read.

No. The child.log is created in one folder with tests, but dosep.py doesn't start few processes to handle tests from the same folder.

[clayborg]

Looks good. Or change to check if file exists first as one of the comments suggested..

lldb/trunk/test/tools/lldb-mi/lldbmi_testcase.py

class MiTestCaseBase(Base):
     def setUp(self):
         Base.setUp(self)
         self.buildDefault()
         self.child_prompt = "(gdb)"
 
     def tearDown(self):
         if self.TraceOn():
             print "\n\nContents of %s:" % self.mylog
+            try:
                 print open(self.mylog, "r").read()
+            except IOError:
+                pass
         Base.tearDown(self)
 
     def spawnLldbMi(self, args=None):
         self.child = pexpect.spawn("%s --interpreter %s" % (
             self.lldbMiExec, args if args else ""))
         self.child.setecho(True)
         self.child.logfile_read = open(self.mylog, "w")
 
     def runCmd(self, cmd):
         self.child.sendline(cmd)
 
     def expect(self, pattern, exactly=False, *args, **kwargs):
         if exactly:
             return self.child.expect_exact(pattern, *args, **kwargs)
         return self.child.expect(pattern, *args, **kwargs)