This is an archive of the discontinued LLVM Phabricator instance.

[OPENMP] Improved codegen for implicit/explicit 'barrier' constructs.
ClosedPublic

Authored by ABataev on Mar 27 2015, 5:29 AM.

Details

Summary

Add particular methods to OpenMP runtime support module for explicit/implicit sync point emission. Also adds processing of 'nowait' clause on worksharing directives.

Diff Detail

Repository
rL LLVM

Event Timeline

ABataev updated this revision to Diff 22788.Mar 27 2015, 5:29 AM
ABataev retitled this revision from to [OPENMP] Improved codegen for implicit/explicit 'barrier' constructs..
ABataev updated this object.
ABataev edited the test plan for this revision. (Show Details)
ABataev added a subscriber: Unknown Object (MLST).
rjmccall added inline comments.Mar 27 2015, 10:41 AM
lib/CodeGen/CGOpenMPRuntime.h
375 ↗(On Diff #22788)

I think you should be able to just pass OMPD_barrier for explicit barriers.

Don't have this take a default argument; make the caller think about it and opt in to OMPD_unknown if they want that.

John, tanks for the review!

lib/CodeGen/CGOpenMPRuntime.h
375 ↗(On Diff #22788)

Ok, I'll do this.

This revision was automatically updated to reflect the committed changes.