This is an archive of the discontinued LLVM Phabricator instance.

Rename test/tools/lldb-gdbserver to test/tools/lldb-server
ClosedPublic

Authored by flackr on Mar 4 2015, 8:50 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

flackr updated this revision to Diff 21206.Mar 4 2015, 8:50 AM
flackr retitled this revision from to Rename test/tools/lldb-gdbserver to test/tools/lldb-server.
flackr updated this object.
flackr edited the test plan for this revision. (Show Details)
flackr added a reviewer: ovyalov.
flackr set the repository for this revision to rL LLVM.
flackr added a subscriber: Unknown Object (MLST).
ovyalov edited edge metadata.Mar 4 2015, 10:38 AM

Please see my comments.

test/tools/lldb-mi/signal/TestMiSignal.py
91 ↗(On Diff #21206)

Please define a constant in this test for "lldb-server"

test/tools/lldb-server/TestLldbGdbServer.py
4 ↗(On Diff #21206)

s/lldb-gdbserver/lldb-server

55 ↗(On Diff #21206)

lldb-server ?

77 ↗(On Diff #21206)

ditto.

test/tools/lldb-server/commandline/TestStubSetSID.py
32 ↗(On Diff #21206)

lldb-server?

test/tools/lldb-server/gdbremote_testcase.py
207 ↗(On Diff #21206)

s/lldb-gdbserver/lldb-server

test/tools/lldb-server/lldbgdbserverutils.py
89 ↗(On Diff #21206)

s/lldb-gdb-server/lldb-server

flackr updated this revision to Diff 21275.Mar 5 2015, 6:48 AM
flackr edited edge metadata.

Address review comments changing test program name in tests.

test/tools/lldb-mi/signal/TestMiSignal.py
91 ↗(On Diff #21206)

Done.

test/tools/lldb-server/TestLldbGdbServer.py
4 ↗(On Diff #21206)

Done.

55 ↗(On Diff #21206)

Done.

77 ↗(On Diff #21206)

Done.

test/tools/lldb-server/commandline/TestStubSetSID.py
32 ↗(On Diff #21206)

Done.

ovyalov accepted this revision.Mar 5 2015, 8:22 AM
ovyalov edited edge metadata.

lgtm

test/tools/lldb-server/lldbgdbserverutils.py
89 ↗(On Diff #21275)

s/lldb-gdbserver/lldb-server

This revision is now accepted and ready to land.Mar 5 2015, 8:22 AM
flackr updated this revision to Diff 21292.Mar 5 2015, 11:32 AM
flackr edited edge metadata.

Comment.

flackr added inline comments.Mar 5 2015, 11:33 AM
test/tools/lldb-server/lldbgdbserverutils.py
89 ↗(On Diff #21275)

Done.

This revision was automatically updated to reflect the committed changes.