This is an archive of the discontinued LLVM Phabricator instance.

TableGen: Initialize ErrorInfo to ~0ULL in MatchInstructionImpl
ClosedPublic

Authored by • tstellarAMD on Feb 27 2015, 10:07 AM.

Reviewers

Summary

This is what all the targets check for and is consistent with the initialized value of MissingFeatures, which is sometimes assigned to ErrorInfo.

• tstellarAMD retitled this revision from to TableGen: Initialize ErrorInfo to ~0ULL in MatchInstructionImpl .

• tstellarAMD updated this object.

• tstellarAMD edited the test plan for this revision. (Show Details)

• tstellarAMD set the repository for this revision to rL LLVM.

• tstellarAMD added a subscriber: Unknown Object (MLST).Feb 27 2015, 10:41 AM

Sounds reasonable, LGTM.

This revision is now accepted and ready to land.Feb 27 2015, 11:25 AM

Path

Size

utils/

TableGen/

2 lines

Context not available.
	OS << " uint64_t MissingFeatures = ~0ULL;\n";	OS << " uint64_t MissingFeatures = ~0ULL;\n";
	OS << " // Set ErrorInfo to the operand that mismatches if it is\n";	OS << " // Set ErrorInfo to the operand that mismatches if it is\n";
	OS << " // wrong for all instances of the instruction.\n";	OS << " // wrong for all instances of the instruction.\n";
	OS << " ErrorInfo = ~0U;\n";	OS << " ErrorInfo = ~0ULL;\n";

	// Emit code to search the table.	// Emit code to search the table.
	OS << " // Find the appropriate table for this asm variant.\n";	OS << " // Find the appropriate table for this asm variant.\n";
Context not available.