This is an archive of the discontinued LLVM Phabricator instance.

Return a current executable's directory from HostInfoAndroid::ComputeSupportExeDirectory.
ClosedPublic

Authored by ovyalov on Feb 24 2015, 5:24 PM.

Details

Summary

HostInfoPosix::ComputeSupportExeDirectory doesn't work on Android because it tries to lookup lldb.so (which doesn't exist on Android since lldb-server uses static linking) and then replaces "/lib" path entry with "/bin".
Since on Android we use the same binary as platform and llgs ComputeSupportExeDirectory can return a current executable's directory.

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 20648.Feb 24 2015, 5:24 PM
ovyalov retitled this revision from to Return a current executable's directory from HostInfoAndroid::ComputeSupportExeDirectory..
ovyalov updated this object.
ovyalov edited the test plan for this revision. (Show Details)
ovyalov added reviewers: tberghammer, vharron.
ovyalov added a subscriber: Unknown Object (MLST).
tberghammer accepted this revision.Feb 25 2015, 10:48 AM
tberghammer edited edge metadata.
This revision is now accepted and ready to land.Feb 25 2015, 10:48 AM
ovyalov closed this revision.Feb 25 2015, 6:53 PM

AFFECTED FILES

/lldb/trunk/include/lldb/Host/android/HostInfoAndroid.h
/lldb/trunk/source/Host/android/HostInfoAndroid.cpp

USERS

ovyalov (Author)

http://reviews.llvm.org/rL230604