This is an archive of the discontinued LLVM Phabricator instance.

Reword ELAST warning
ClosedPublic

Authored by jfb on Feb 22 2015, 11:45 AM.

Reviewers

danalbert

Commits

Summary

GCC emits a pretty amusing warning when there are apostrophes in a #warning:

warning: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wliteral-suffix]

Reword the warning to avoid this, and be more consistent with other warnings in libc++.

jfb retitled this revision from to Reword ELAST warning.

jfb updated this object.

jfb added a reviewer: danalbert.

jfb added a subscriber: Unknown Object (MLST).

LGTM.

This revision is now accepted and ready to land.Feb 23 2015, 4:32 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

libcxx/

trunk/

src/

2 lines

	Show All 24 Lines
	#elif defined(__APPLE__)			#elif defined(__APPLE__)
	// No _LIBCPP_ELAST needed on Apple			// No _LIBCPP_ELAST needed on Apple
	#elif defined(__sun__)			#elif defined(__sun__)
	#define _LIBCPP_ELAST ESTALE			#define _LIBCPP_ELAST ESTALE
	#elif defined(_WIN32)			#elif defined(_WIN32)
	#define _LIBCPP_ELAST _sys_nerr			#define _LIBCPP_ELAST _sys_nerr
	#else			#else
	// Warn here so that the person doing the libcxx port has an easier time:			// Warn here so that the person doing the libcxx port has an easier time:
	#warning This platform's ELAST hasn't been ported yet			#warning ELAST for this platform not yet implemented
	#endif			#endif

	#endif // _LIBCPP_CONFIG_ELAST			#endif // _LIBCPP_CONFIG_ELAST