This is an archive of the discontinued LLVM Phabricator instance.

[LoopAccesses] Change debug messages from LV to LAA
ClosedPublic

Authored by anemet on Feb 16 2015, 2:20 PM.

Details

Summary

This is part of the patchset that converts LoopAccessAnalysis into an
actual analysis pass.

Diff Detail

Event Timeline

anemet updated this revision to Diff 20055.Feb 16 2015, 2:20 PM
anemet retitled this revision from to [LoopAccesses] Change debug messages from LV to LAA.
anemet updated this object.
anemet edited the test plan for this revision. (Show Details)
anemet added reviewers: hfinkel, aschwaighofer, nadav.
anemet added a subscriber: Unknown Object (MLST).
hfinkel added inline comments.Feb 16 2015, 4:51 PM
lib/Analysis/LoopAccessAnalysis.cpp
35

Shouldn't this be a function parameter, so you get the right remarks based on the calling transformation?

anemet added inline comments.Feb 16 2015, 4:54 PM
lib/Analysis/LoopAccessAnalysis.cpp
35

I was going to leave that to later when we have multiple clients besides LV but you're right this looks a bit awkward now. I'll change it.

anemet updated this revision to Diff 20110.Feb 17 2015, 2:33 PM

Address Hal's comment: make pass name an argument to emitAnalysis.

hfinkel accepted this revision.Feb 17 2015, 7:29 PM
hfinkel edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Feb 17 2015, 7:29 PM
anemet closed this revision.Mar 1 2015, 9:35 PM

r229894