This is an archive of the discontinued LLVM Phabricator instance.

Fix TestDataFormatter* on Linux
ClosedPublic

Authored by vharron on Feb 15 2015, 5:51 PM.

Details

Reviewers
vharron
clayborg
Summary

llvm::StringRef doesn't make a copy of a string, it just holds a
reference. When special_directions_stream went out of scope,
special_directions was holding on to a stale pointer.

Moving special_directions_stream into a higher scope to keep
special_directions pointing to a valid string.

Diff Detail

Event Timeline

vharron updated this revision to Diff 19997.Feb 15 2015, 5:51 PM
vharron retitled this revision from to Fix TestDataFormatter* on Linux.
vharron updated this object.
vharron edited the test plan for this revision. (Show Details)
vharron added a reviewer: clayborg.
vharron added a subscriber: Unknown Object (MLST).
vharron accepted this revision.Feb 18 2015, 3:19 PM
vharron added a reviewer: vharron.

Committed revision 229767.

This revision is now accepted and ready to land.Feb 18 2015, 3:19 PM
vharron closed this revision.Feb 18 2015, 3:19 PM