This is an archive of the discontinued LLVM Phabricator instance.

Differential D7620

Improve robustness of dependency-generation-crash.c test.
ClosedPublic

Authored by MatzeB on Feb 13 2015, 11:28 AM.

Details

Reviewers
mcrosier
Commits
rGe0fc8cabda04: Improve robustness of dependency-generation-crash.c test.
rC231009: Improve robustness of dependency-generation-crash.c test.
rL231009: Improve robustness of dependency-generation-crash.c test.
Summary

The test wants to provoke a failure when opening the output file.
Using chmod 0 on the output file does not work reliably on all
filesystems or when running the test as root.
Change the test to use a nonexistant directory instead.

Diff Detail

Repository
rL LLVM

Event Timeline

MatzeB updated this revision to Diff 19911.Feb 13 2015, 11:28 AM
MatzeB retitled this revision from to Improve robustness of dependency-generation-crash.c test..
MatzeB updated this object.
MatzeB edited the test plan for this revision. (Show Details)
MatzeB added a reviewer: mcrosier.
MatzeB set the repository for this revision to rL LLVM.
MatzeB added a subscriber: Unknown Object (MLST).
MatzeB added a comment.Feb 20 2015, 10:47 AM

ping.

MatzeB added a comment.Mar 2 2015, 10:28 AM

ping^2

mcrosier accepted this revision.Mar 2 2015, 11:55 AM
mcrosier edited edge metadata.

Seems reasonable.

This revision is now accepted and ready to land.Mar 2 2015, 11:55 AM
Closed by commit rL231009: Improve robustness of dependency-generation-crash.c test. (authored by matze). · Explain WhyMar 2 2015, 12:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
test/
Frontend/
5 lines

Diff 21032

cfe/trunk/test/Frontend/dependency-generation-crash.c

// RUN: touch %t // RUN: not %clang_cc1 -E -dependency-file bla -MT %t/doesnotexist/bla.o -MP -o $t/doesnotexist/bla.o -x c /dev/null 2>&1 | FileCheck %s
// RUN: chmod 0 %t
// RUN: not %clang_cc1 -E -dependency-file bla -MT %t -MP -o %t -x c /dev/null 2>&1 | FileCheck %s
// RUN: rm -f %t
// CHECK: error: unable to open output file // CHECK: error: unable to open output file
// rdar://9286457 // rdar://9286457