This is an archive of the discontinued LLVM Phabricator instance.

[mips] Use isa<> instead of dyn_cast<> with unused value. NFC.
ClosedPublic

Authored by vkalintiris on Feb 13 2015, 8:57 AM.

Reviewers

Commits

vkalintiris retitled this revision from to [mips] Use isa<> instead of dyn_cast<> with unused value. NFC..

vkalintiris updated this object.

vkalintiris edited the test plan for this revision. (Show Details)

vkalintiris added a reviewer: dsanders.

vkalintiris added a subscriber: Unknown Object (MLST).

LGTM, please commit.

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

Target/

Mips/

4 lines

Show First 20 Lines • Show All 2,285 Lines • ▼ Show 20 Lines	lowerEXTRACT_VECTOR_ELT(SDValue Op, SelectionDAG &DAG) const {
}		}

return Op;		return Op;
}		}

static bool isConstantOrUndef(const SDValue Op) {		static bool isConstantOrUndef(const SDValue Op) {
if (Op->getOpcode() == ISD::UNDEF)		if (Op->getOpcode() == ISD::UNDEF)
return true;		return true;
if (dyn_cast<ConstantSDNode>(Op))		if (isa<ConstantSDNode>(Op))
return true;		return true;
if (dyn_cast<ConstantFPSDNode>(Op))		if (isa<ConstantFPSDNode>(Op))
return true;		return true;
return false;		return false;
}		}

static bool isConstantOrUndefBUILD_VECTOR(const BuildVectorSDNode *Op) {		static bool isConstantOrUndefBUILD_VECTOR(const BuildVectorSDNode *Op) {
for (unsigned i = 0; i < Op->getNumOperands(); ++i)		for (unsigned i = 0; i < Op->getNumOperands(); ++i)
if (isConstantOrUndef(Op->getOperand(i)))		if (isConstantOrUndef(Op->getOperand(i)))
return true;		return true;
▲ Show 20 Lines • Show All 933 Lines • Show Last 20 Lines