Page MenuHomePhabricator

Correctly combine alias.scope metadata by a union instead of intersecting
ClosedPublic

Authored by dotdash on Feb 8 2015, 7:36 AM.

Details

Summary

The alias.scope metadata represents sets of things an instruction might
alias with. When generically combining the metadata from two
instructions the result must be the union of the original sets, because
the new instruction might alias with anything any of the original
instructions aliased with.

Diff Detail

Repository
rL LLVM

Event Timeline

dotdash updated this revision to Diff 19547.Feb 8 2015, 7:36 AM
dotdash retitled this revision from to Correctly combine alias.scope metadata by a union instead of intersecting.
dotdash updated this object.
dotdash edited the test plan for this revision. (Show Details)
dotdash added a reviewer: hfinkel.
dotdash added a subscriber: Unknown Object (MLST).
hfinkel accepted this revision.Feb 8 2015, 9:05 AM
hfinkel edited edge metadata.

Ack, you're right. Thanks for catching that. LGTM.

lib/Analysis/TypeBasedAliasAnalysis.cpp
627 ↗(On Diff #19547)

Line too long?

This revision is now accepted and ready to land.Feb 8 2015, 9:05 AM
dotdash updated this revision to Diff 19548.Feb 8 2015, 9:08 AM
dotdash edited edge metadata.

Fixed the line length.

This revision was automatically updated to reflect the committed changes.