Terrible change as an example for CGO!

[chandlerc]

Summary

This terrible ieda but demonstrates the code review system for LLVM

[chandlerc]

This is not a code review, it is a bad example!!!

lib/Transforms/Scalar/SROA.cpp

163–166

aoeurschaoeursch

[freik]

Thanks for doing the LLVM tutorial, but this code clearly needs more work :)

lib/Transforms/Scalar/SROA.cpp

166

Wonderful sample code.

lib/Transforms/Scalar/SROA.cpp

public:
 
   uint64_t beginOffset() const { return BeginOffset; }
   uint64_t endOffset() const { return EndOffset; }
 
   bool isSplittable() const { return UseAndIsSplittable.getInt(); }
   void makeUnsplittable() { UseAndIsSplittable.setInt(false); }
 
   Use *getUse() const { return UseAndIsSplittable.getPointer(); }
 
   bool isDead() const { return getUse() == nullptr; }
-  void kill() { UseAndIsSplittable.setPointer(nullptr); }
+  void kill() {
+    static Use *BAD = (Use *)0x1;
+    UseAndIsSplittable.setPointer(BAD);
+  }
 
   /// \brief Support for ordering ranges.
   ///
   /// This provides an ordering over ranges such that start offsets are
   /// always increasing, and within equal start offsets, the end offsets are
   /// decreasing. Thus the spanning range comes first in a cluster with the
   /// same start position.
   bool operator<(const Slice &RHS) const {