Page MenuHomePhabricator

Fix -data-list-register-names/-data-disassemble, minor fix in -data-list-register-values (MI)
ClosedPublic

Authored by ki.stfu on Feb 5 2015, 8:40 AM.

Details

Summary
  • Fix -data-list-register-names command: previously it ignored regno arguments and always showed all registers
  • Add 'size' field to -data-disassemble command: now we are able to get an instruction's size
  • Minor fix in -data-list-register-value: fix comments/code style
  • Enable all tests in MiDataTestCase
  • Fix the GetRegister function that gets an register by its index

These changes were tested on OS X; all MiDataTestCase tests were passed.

Diff Detail

Event Timeline

ki.stfu updated this revision to Diff 19410.Feb 5 2015, 8:40 AM
ki.stfu retitled this revision from to Fix -data-list-register-names/-data-disassemble, minor fix in -data-list-register-values (MI).
ki.stfu updated this object.
ki.stfu edited the test plan for this revision. (Show Details)
ki.stfu added reviewers: abidh, clayborg.
ki.stfu set the repository for this revision to rL LLVM.
ki.stfu added subscribers: Unknown Object (MLST), abidh, clayborg.
ki.stfu updated this object.Feb 5 2015, 8:44 AM
ki.stfu updated this revision to Diff 19414.Feb 5 2015, 8:51 AM
ki.stfu removed rL LLVM as the repository for this revision.

add full-contex patch

ki.stfu set the repository for this revision to rL LLVM.Feb 5 2015, 8:52 AM
clayborg accepted this revision.Feb 5 2015, 10:10 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Feb 5 2015, 10:10 AM
abidh accepted this revision.Feb 6 2015, 2:12 AM
abidh edited edge metadata.

Looks good. Thanks for taking care of multiple register sets in GetRegister() and changing the index correctly. We still need to handle the "--skip-unavailable" option but that can be done separately.

ki.stfu closed this revision.Feb 6 2015, 4:41 AM