This is an archive of the discontinued LLVM Phabricator instance.

[UBSan] Enable -Wglobal-constructors.
ClosedPublic

Authored by ygribov on Feb 4 2015, 5:33 AM.

Reviewers

samsonov
eugenis

ygribov retitled this revision from to [UBSan] Enable -Wglobal-constructors..

ygribov updated this object.

ygribov edited the test plan for this revision. (Show Details)

ygribov set the repository for this revision to rL LLVM.

ygribov added a subscriber: Unknown Object (MLST).

LGTM

This revision is now accepted and ready to land.Feb 4 2015, 2:04 PM

Landed in r228384.

Path

Size

lib/

ubsan/

5 lines

Show All 11 Lines	set(UBSAN_CXX_SOURCES
ubsan_handlers_cxx.cc		ubsan_handlers_cxx.cc
ubsan_type_hash.cc		ubsan_type_hash.cc
)		)

include_directories(..)		include_directories(..)

set(UBSAN_CFLAGS ${SANITIZER_COMMON_CFLAGS})		set(UBSAN_CFLAGS ${SANITIZER_COMMON_CFLAGS})
append_no_rtti_flag(UBSAN_CFLAGS)		append_no_rtti_flag(UBSAN_CFLAGS)
		append_list_if(COMPILER_RT_HAS_WGLOBAL_CONSTRUCTORS_FLAG -Wglobal-constructors
		UBSAN_CFLAGS)

set(UBSAN_CXXFLAGS ${SANITIZER_COMMON_CFLAGS})		set(UBSAN_CXXFLAGS ${SANITIZER_COMMON_CFLAGS})
		append_list_if(COMPILER_RT_HAS_WGLOBAL_CONSTRUCTORS_FLAG -Wglobal-constructors
		UBSAN_CXXFLAGS)

add_custom_target(ubsan)		add_custom_target(ubsan)

if(APPLE)		if(APPLE)
# Build universal binary on APPLE.		# Build universal binary on APPLE.
add_compiler_rt_osx_static_runtime(clang_rt.ubsan_osx		add_compiler_rt_osx_static_runtime(clang_rt.ubsan_osx
ARCH ${UBSAN_SUPPORTED_ARCH}		ARCH ${UBSAN_SUPPORTED_ARCH}
SOURCES ${UBSAN_SOURCES} ${UBSAN_CXX_SOURCES}		SOURCES ${UBSAN_SOURCES} ${UBSAN_CXX_SOURCES}
Show All 29 Lines