This is an archive of the discontinued LLVM Phabricator instance.

Differential D7198

[mips] Use __clear_cache builtin instead of cacheflush()
ClosedPublic

Authored by petarj on Jan 27 2015, 8:12 AM.

Details

Reviewers
dsanders
Commits
rGd4e27d7e93d6: Merging r227269: --------------------------------------------------------------…
rG4a1184903445: [mips] Use __clear_cache builtin instead of cacheflush()
rL227269: [mips] Use __clear_cache builtin instead of cacheflush()
Summary

Use __clear_cache builtin instead of cacheflush() in
Unix Memory::InvalidateInstructionCache().

Diff Detail

Repository
rL LLVM

Event Timeline

petarj updated this revision to Diff 18817.Jan 27 2015, 8:12 AM
petarj retitled this revision from to [mips] Use __clear_cache builtin instead of cacheflush().
petarj updated this object.
petarj edited the test plan for this revision. (Show Details)
petarj added a reviewer: dsanders.
petarj set the repository for this revision to rL LLVM.
petarj added a subscriber: Unknown Object (MLST).
Closed by commit rL227269: [mips] Use __clear_cache builtin instead of cacheflush() (authored by petarj). · Explain WhyJan 27 2015, 3:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Support/
Unix/
15 lines

Diff 18859

llvm/trunk/lib/Support/Unix/Memory.inc

Show First 20 Lines • Show All 327 Lines • ▼ Show 20 Lines# if (defined(__POWERPC__) || defined (__ppc__) || \
for (intptr_t Line = StartLine; Line < EndLine; Line += LineSize) for (intptr_t Line = StartLine; Line < EndLine; Line += LineSize)
asm volatile("dcbf 0, %0" : : "r"(Line)); asm volatile("dcbf 0, %0" : : "r"(Line));
asm volatile("sync"); asm volatile("sync");
for (intptr_t Line = StartLine; Line < EndLine; Line += LineSize) for (intptr_t Line = StartLine; Line < EndLine; Line += LineSize)
asm volatile("icbi 0, %0" : : "r"(Line)); asm volatile("icbi 0, %0" : : "r"(Line));
asm volatile("isync"); asm volatile("isync");
# elif (defined(__arm__) || defined(__aarch64__)) && defined(__GNUC__) # elif (defined(__arm__) || defined(__aarch64__) || defined(__mips__)) && \
defined(__GNUC__)
// FIXME: Can we safely always call this for __GNUC__ everywhere? // FIXME: Can we safely always call this for __GNUC__ everywhere?
const char *Start = static_cast<const char *>(Addr); const char *Start = static_cast<const char *>(Addr);
const char *End = Start + Len; const char *End = Start + Len;
__clear_cache(const_cast<char *>(Start), const_cast<char *>(End)); __clear_cache(const_cast<char *>(Start), const_cast<char *>(End));
# elif defined(__mips__)
const char *Start = static_cast<const char *>(Addr);
# if defined(ANDROID)
// The declaration of "cacheflush" in Android bionic:
// extern int cacheflush(long start, long end, long flags);
const char *End = Start + Len;
long LStart = reinterpret_cast<long>(const_cast<char *>(Start));
long LEnd = reinterpret_cast<long>(const_cast<char *>(End));
cacheflush(LStart, LEnd, BCACHE);
# else
cacheflush(const_cast<char *>(Start), Len, BCACHE);
# endif
# endif # endif
#endif // end apple #endif // end apple
ValgrindDiscardTranslations(Addr, Len); ValgrindDiscardTranslations(Addr, Len);
} }
} // namespace sys } // namespace sys
} // namespace llvm } // namespace llvm