This is an archive of the discontinued LLVM Phabricator instance.

Differential D7045

[OPENMP] Initial codegen for 'single' directive.
ClosedPublic

Authored by ABataev on Jan 18 2015, 9:33 PM.

Details

Reviewers
rjmccall
• fraggamuffin
• ejstotzer
Commits
rG6956e2e68338: [OPENMP] Initial codegen for 'single' directive. This patch emits the following…
rC228275: [OPENMP] Initial codegen for 'single' directive.
rL228275: [OPENMP] Initial codegen for 'single' directive.
Summary

This patch emits the following code for the single directive:

#pragma omp single
<body>

<---->

if(__kmpc_single(...)) {
  <body>
  __kmpc_end_single(...);
}

Diff Detail

Repository
rL LLVM

Event Timeline

ABataev updated this revision to Diff 18365.Jan 18 2015, 9:33 PM
ABataev retitled this revision from to [OPENMP] Initial codegen for 'single' directive..
ABataev updated this object.
ABataev edited the test plan for this revision. (Show Details)
ABataev added reviewers: rjmccall, • fraggamuffin, • ejstotzer.
ABataev added a subscriber: Unknown Object (MLST).
ABataev added a comment.Jan 29 2015, 7:55 PM

Ping!

rjmccall edited edge metadata.Feb 4 2015, 10:51 AM

LGTM.

Closed by commit rL228275: [OPENMP] Initial codegen for 'single' directive. (authored by ABataev). · Explain WhyFeb 4 2015, 10:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
lib/
CodeGen/
11 lines
49 lines
9 lines
test/
OpenMP/
46 lines

Diff 19380

cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines enum OpenMPRTLFunction {
OMPRTL__kmpc_flush, OMPRTL__kmpc_flush,
// Call to kmp_int32 __kmpc_master(ident_t *, kmp_int32 global_tid); // Call to kmp_int32 __kmpc_master(ident_t *, kmp_int32 global_tid);
OMPRTL__kmpc_master, OMPRTL__kmpc_master,
// Call to void __kmpc_end_master(ident_t *, kmp_int32 global_tid); // Call to void __kmpc_end_master(ident_t *, kmp_int32 global_tid);
OMPRTL__kmpc_end_master, OMPRTL__kmpc_end_master,
// Call to kmp_int32 __kmpc_omp_taskyield(ident_t *, kmp_int32 global_tid, // Call to kmp_int32 __kmpc_omp_taskyield(ident_t *, kmp_int32 global_tid,
// int end_part); // int end_part);
OMPRTL__kmpc_omp_taskyield, OMPRTL__kmpc_omp_taskyield,
// Call to kmp_int32 __kmpc_single(ident_t *, kmp_int32 global_tid);
OMPRTL__kmpc_single,
// Call to void __kmpc_end_single(ident_t *, kmp_int32 global_tid);
OMPRTL__kmpc_end_single,
}; };
/// \brief Values for bit flags used in the ident_t to describe the fields. /// \brief Values for bit flags used in the ident_t to describe the fields.
/// All enumeric elements are named and described in accordance with the code /// All enumeric elements are named and described in accordance with the code
/// from http://llvm.org/svn/llvm-project/openmp/trunk/runtime/src/kmp.h /// from http://llvm.org/svn/llvm-project/openmp/trunk/runtime/src/kmp.h
enum OpenMPLocationFlags { enum OpenMPLocationFlags {
/// \brief Use trampoline for internal microtask. /// \brief Use trampoline for internal microtask.
OMP_IDENT_IMD = 0x01, OMP_IDENT_IMD = 0x01,
▲ Show 20 Lines • Show All 205 Lines • ▼ Show 20 Linespublic:
/// master region. /// master region.
virtual void EmitOMPMasterRegion(CodeGenFunction &CGF, virtual void EmitOMPMasterRegion(CodeGenFunction &CGF,
const std::function<void()> &MasterOpGen, const std::function<void()> &MasterOpGen,
SourceLocation Loc); SourceLocation Loc);
/// \brief Emits code for a taskyield directive. /// \brief Emits code for a taskyield directive.
virtual void EmitOMPTaskyieldCall(CodeGenFunction &CGF, SourceLocation Loc); virtual void EmitOMPTaskyieldCall(CodeGenFunction &CGF, SourceLocation Loc);
/// \brief Emits a single region.
/// \param SingleOpGen Generator for the statement associated with the given
/// single region.
virtual void EmitOMPSingleRegion(CodeGenFunction &CGF,
const std::function<void()> &SingleOpGen,
SourceLocation Loc);
/// \brief Emits explicit barrier for OpenMP threads. /// \brief Emits explicit barrier for OpenMP threads.
/// \param IsExplicit true, if it is explicitly specified barrier. /// \param IsExplicit true, if it is explicitly specified barrier.
/// ///
virtual void EmitOMPBarrierCall(CodeGenFunction &CGF, SourceLocation Loc, virtual void EmitOMPBarrierCall(CodeGenFunction &CGF, SourceLocation Loc,
bool IsExplicit = true); bool IsExplicit = true);
/// \brief Check if the specified \a ScheduleKind is static non-chunked. /// \brief Check if the specified \a ScheduleKind is static non-chunked.
/// This kind of worksharing directive is emitted without outer loop. /// This kind of worksharing directive is emitted without outer loop.
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines

cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp

Show First 20 Lines • Show All 478 Lines • ▼ Show 20 Lines case OMPRTL__kmpc_omp_taskyield: {
// Build kmp_int32 __kmpc_omp_taskyield(ident_t *, kmp_int32 global_tid, // Build kmp_int32 __kmpc_omp_taskyield(ident_t *, kmp_int32 global_tid,
// int end_part); // int end_part);
llvm::Type *TypeParams[] = {getIdentTyPointerTy(), CGM.Int32Ty, CGM.IntTy}; llvm::Type *TypeParams[] = {getIdentTyPointerTy(), CGM.Int32Ty, CGM.IntTy};
llvm::FunctionType *FnTy = llvm::FunctionType *FnTy =
llvm::FunctionType::get(CGM.Int32Ty, TypeParams, /*isVarArg=*/false); llvm::FunctionType::get(CGM.Int32Ty, TypeParams, /*isVarArg=*/false);
RTLFn = CGM.CreateRuntimeFunction(FnTy, /*Name=*/"__kmpc_omp_taskyield"); RTLFn = CGM.CreateRuntimeFunction(FnTy, /*Name=*/"__kmpc_omp_taskyield");
break; break;
} }
case OMPRTL__kmpc_single: {
// Build kmp_int32 __kmpc_single(ident_t *loc, kmp_int32 global_tid);
llvm::Type *TypeParams[] = {getIdentTyPointerTy(), CGM.Int32Ty};
llvm::FunctionType *FnTy =
llvm::FunctionType::get(CGM.Int32Ty, TypeParams, /*isVarArg=*/false);
RTLFn = CGM.CreateRuntimeFunction(FnTy, /*Name=*/"__kmpc_single");
break;
}
case OMPRTL__kmpc_end_single: {
// Build void __kmpc_end_single(ident_t *loc, kmp_int32 global_tid);
llvm::Type *TypeParams[] = {getIdentTyPointerTy(), CGM.Int32Ty};
llvm::FunctionType *FnTy =
llvm::FunctionType::get(CGM.VoidTy, TypeParams, /*isVarArg=*/false);
RTLFn = CGM.CreateRuntimeFunction(FnTy, /*Name=*/"__kmpc_end_single");
break;
}
} }
return RTLFn; return RTLFn;
} }
llvm::Constant * llvm::Constant *
CGOpenMPRuntime::getOrCreateThreadPrivateCache(const VarDecl *VD) { CGOpenMPRuntime::getOrCreateThreadPrivateCache(const VarDecl *VD) {
// Lookup the entry, lazily creating it if necessary. // Lookup the entry, lazily creating it if necessary.
return GetOrCreateInternalVariable(CGM.Int8PtrPtrTy, return GetOrCreateInternalVariable(CGM.Int8PtrPtrTy,
▲ Show 20 Lines • Show All 305 Lines • ▼ Show 20 Linesvoid CGOpenMPRuntime::EmitOMPTaskyieldCall(CodeGenFunction &CGF,
// Build call __kmpc_omp_taskyield(loc, thread_id, 0); // Build call __kmpc_omp_taskyield(loc, thread_id, 0);
llvm::Value *Args[] = { llvm::Value *Args[] = {
EmitOpenMPUpdateLocation(CGF, Loc), GetOpenMPThreadID(CGF, Loc), EmitOpenMPUpdateLocation(CGF, Loc), GetOpenMPThreadID(CGF, Loc),
llvm::ConstantInt::get(CGM.IntTy, /*V=*/0, /*isSigned=*/true)}; llvm::ConstantInt::get(CGM.IntTy, /*V=*/0, /*isSigned=*/true)};
auto RTLFn = CreateRuntimeFunction(OMPRTL__kmpc_omp_taskyield); auto RTLFn = CreateRuntimeFunction(OMPRTL__kmpc_omp_taskyield);
CGF.EmitRuntimeCall(RTLFn, Args); CGF.EmitRuntimeCall(RTLFn, Args);
} }
void CGOpenMPRuntime::EmitOMPSingleRegion(
CodeGenFunction &CGF, const std::function<void()> &SingleOpGen,
SourceLocation Loc) {
// if(__kmpc_single(ident_t *, gtid)) {
// SingleOpGen();
// __kmpc_end_single(ident_t *, gtid);
// }
// Prepare arguments and build a call to __kmpc_single
llvm::Value *Args[] = {EmitOpenMPUpdateLocation(CGF, Loc),
GetOpenMPThreadID(CGF, Loc)};
auto RTLFn = CreateRuntimeFunction(OMPRTL__kmpc_single);
auto *IsSingle = CGF.EmitRuntimeCall(RTLFn, Args);
EmitOMPIfStmt(CGF, IsSingle, [&]() -> void {
SingleOpGen();
// Build a call to __kmpc_end_single.
// OpenMP [1.2.2 OpenMP Language Terminology]
// For C/C++, an executable statement, possibly compound, with a single
// entry at the top and a single exit at the bottom, or an OpenMP construct.
// * Access to the structured block must not be the result of a branch.
// * The point of exit cannot be a branch out of the structured block.
// * The point of entry must not be a call to setjmp().
// * longjmp() and throw() must not violate the entry/exit criteria.
// * An expression statement, iteration statement, selection statement, or
// try block is considered to be a structured block if the corresponding
// compound statement obtained by enclosing it in { and } would be a
// structured block.
// It is analyzed in Sema, so we can just call __kmpc_end_single() on
// fallthrough rather than pushing a normal cleanup for it.
RTLFn = CreateRuntimeFunction(OMPRTL__kmpc_end_single);
CGF.EmitRuntimeCall(RTLFn, Args);
});
}
void CGOpenMPRuntime::EmitOMPBarrierCall(CodeGenFunction &CGF, void CGOpenMPRuntime::EmitOMPBarrierCall(CodeGenFunction &CGF,
SourceLocation Loc, bool IsExplicit) { SourceLocation Loc, bool IsExplicit) {
// Build call __kmpc_cancel_barrier(loc, thread_id); // Build call __kmpc_cancel_barrier(loc, thread_id);
auto Flags = static_cast<OpenMPLocationFlags>( auto Flags = static_cast<OpenMPLocationFlags>(
OMP_IDENT_KMPC | OMP_IDENT_KMPC |
(IsExplicit ? OMP_IDENT_BARRIER_EXPL : OMP_IDENT_BARRIER_IMPL)); (IsExplicit ? OMP_IDENT_BARRIER_EXPL : OMP_IDENT_BARRIER_IMPL));
// Build call __kmpc_cancel_barrier(loc, thread_id); // Build call __kmpc_cancel_barrier(loc, thread_id);
// Replace __kmpc_barrier() function by __kmpc_cancel_barrier() because this // Replace __kmpc_barrier() function by __kmpc_cancel_barrier() because this
▲ Show 20 Lines • Show All 132 Lines • Show Last 20 Lines

cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp

Show First 20 Lines • Show All 701 Lines • ▼ Show 20 Lines
void CodeGenFunction::EmitOMPSectionsDirective(const OMPSectionsDirective &) { void CodeGenFunction::EmitOMPSectionsDirective(const OMPSectionsDirective &) {
llvm_unreachable("CodeGen for 'omp sections' is not supported yet."); llvm_unreachable("CodeGen for 'omp sections' is not supported yet.");
} }
void CodeGenFunction::EmitOMPSectionDirective(const OMPSectionDirective &) { void CodeGenFunction::EmitOMPSectionDirective(const OMPSectionDirective &) {
llvm_unreachable("CodeGen for 'omp section' is not supported yet."); llvm_unreachable("CodeGen for 'omp section' is not supported yet.");
} }
void CodeGenFunction::EmitOMPSingleDirective(const OMPSingleDirective &) { void CodeGenFunction::EmitOMPSingleDirective(const OMPSingleDirective &S) {
llvm_unreachable("CodeGen for 'omp single' is not supported yet."); CGM.getOpenMPRuntime().EmitOMPSingleRegion(*this, [&]() -> void {
InlinedOpenMPRegion Region(*this, S.getAssociatedStmt());
RunCleanupsScope Scope(*this);
EmitStmt(cast<CapturedStmt>(S.getAssociatedStmt())->getCapturedStmt());
EnsureInsertPoint();
}, S.getLocStart());
} }
void CodeGenFunction::EmitOMPMasterDirective(const OMPMasterDirective &S) { void CodeGenFunction::EmitOMPMasterDirective(const OMPMasterDirective &S) {
CGM.getOpenMPRuntime().EmitOMPMasterRegion(*this, [&]() -> void { CGM.getOpenMPRuntime().EmitOMPMasterRegion(*this, [&]() -> void {
InlinedOpenMPRegion Region(*this, S.getAssociatedStmt()); InlinedOpenMPRegion Region(*this, S.getAssociatedStmt());
RunCleanupsScope Scope(*this); RunCleanupsScope Scope(*this);
EmitStmt(cast<CapturedStmt>(S.getAssociatedStmt())->getCapturedStmt()); EmitStmt(cast<CapturedStmt>(S.getAssociatedStmt())->getCapturedStmt());
EnsureInsertPoint(); EnsureInsertPoint();
▲ Show 20 Lines • Show All 192 Lines • Show Last 20 Lines

cfe/trunk/test/OpenMP/single_codegen.cpp

PropertyOld ValueNew Value
svn:eol-stylenullnative
svn:keywordsnullAuthor Date Id Rev URL
svn:mime-typenulltext/plain
// RUN: %clang_cc1 -verify -fopenmp=libiomp5 -x c++ -emit-llvm %s -fexceptions -fcxx-exceptions -o - | FileCheck %s
// RUN: %clang_cc1 -fopenmp=libiomp5 -x c++ -std=c++11 -triple x86_64-unknown-unknown -fexceptions -fcxx-exceptions -emit-pch -o %t %s
// RUN: %clang_cc1 -fopenmp=libiomp5 -x c++ -triple x86_64-unknown-unknown -fexceptions -fcxx-exceptions -std=c++11 -include-pch %t -verify %s -emit-llvm -o - | FileCheck %s
// expected-no-diagnostics
#ifndef HEADER
#define HEADER
// CHECK: [[IDENT_T_TY:%.+]] = type { i32, i32, i32, i32, i8* }
// CHECK: define void [[FOO:@.+]]()
void foo() {}
// CHECK-LABEL: @main
int main() {
// CHECK: [[A_ADDR:%.+]] = alloca i8
char a;
// CHECK: [[GTID:%.+]] = call i32 @__kmpc_global_thread_num([[IDENT_T_TY]]* [[DEFAULT_LOC:@.+]])
// CHECK: [[RES:%.+]] = call i32 @__kmpc_single([[IDENT_T_TY]]* [[DEFAULT_LOC]], i32 [[GTID]])
// CHECK-NEXT: [[IS_SINGLE:%.+]] = icmp ne i32 [[RES]], 0
// CHECK-NEXT: br i1 [[IS_SINGLE]], label {{%?}}[[THEN:.+]], label {{%?}}[[EXIT:.+]]
// CHECK: [[THEN]]
// CHECK-NEXT: store i8 2, i8* [[A_ADDR]]
// CHECK-NEXT: call void @__kmpc_end_single([[IDENT_T_TY]]* [[DEFAULT_LOC]], i32 [[GTID]])
// CHECK-NEXT: br label {{%?}}[[EXIT]]
// CHECK: [[EXIT]]
#pragma omp single
a = 2;
// CHECK: [[RES:%.+]] = call i32 @__kmpc_single([[IDENT_T_TY]]* [[DEFAULT_LOC]], i32 [[GTID]])
// CHECK-NEXT: [[IS_SINGLE:%.+]] = icmp ne i32 [[RES]], 0
// CHECK-NEXT: br i1 [[IS_SINGLE]], label {{%?}}[[THEN:.+]], label {{%?}}[[EXIT:.+]]
// CHECK: [[THEN]]
// CHECK-NEXT: call void [[FOO]]()
// CHECK-NEXT: call void @__kmpc_end_single([[IDENT_T_TY]]* [[DEFAULT_LOC]], i32 [[GTID]])
// CHECK-NEXT: br label {{%?}}[[EXIT]]
// CHECK: [[EXIT]]
#pragma omp single
foo();
// CHECK-NOT: call i32 @__kmpc_single
// CHECK-NOT: call void @__kmpc_end_single
return a;
}
#endif