This is an archive of the discontinued LLVM Phabricator instance.

[OCaml] fix syntax errors in linker test
ClosedPublic

Authored by artagnon on Dec 23 2014, 5:43 PM.

Details

Reviewers
whitequark
Summary

A couple of loose ends.

Diff Detail

Event Timeline

artagnon updated this revision to Diff 17617.Dec 23 2014, 5:43 PM
artagnon retitled this revision from to [OCaml] fix syntax errors in linker test.
artagnon updated this object.
artagnon edited the test plan for this revision. (Show Details)
artagnon added a reviewer: whitequark.
artagnon added a subscriber: Unknown Object (MLST).
whitequark added inline comments.Dec 23 2014, 5:48 PM
test/Bindings/OCaml/linker.ml
54

This doesn't make sense. The signature of link_modules is:

val link_modules : Llvm.llmodule -> Llvm.llmodule -> Mode.t -> unit

See d27b926.

-external link_modules : Llvm.llmodule -> Llvm.llmodule -> Mode.t -> unit
+external link_modules : Llvm.llmodule -> Llvm.llmodule -> unit

whitequark accepted this revision.Dec 24 2014, 5:07 AM
whitequark edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2014, 5:07 AM
whitequark closed this revision.Dec 24 2014, 5:07 AM