This is an archive of the discontinued LLVM Phabricator instance.

Fix suppressions file usage
ClosedPublic

Authored by filcab on Dec 16 2014, 6:51 AM.

Details

Summary

Always quote suppressions files given to *_OPTIONS.
This will make it not break when given full Windows paths (otherwise,
parsing would stop after the drive's letter + ':').

Also fix one or two cases where the suppression files' extensions were
not *.supp.

Diff Detail

Repository
rL LLVM

Event Timeline

filcab updated this revision to Diff 17333.Dec 16 2014, 6:51 AM
filcab retitled this revision from to Fix suppressions file usage.
filcab updated this object.
filcab edited the test plan for this revision. (Show Details)
filcab added reviewers: samsonov, kcc.
filcab added a subscriber: Unknown Object (MLST).
filcab updated this revision to Diff 17334.Dec 16 2014, 6:56 AM

Quoted one mode suppression file usage I missed earlier.

samsonov added inline comments.Dec 16 2014, 11:31 AM
test/lsan/TestCases/suppressions_file.cc
7 ↗(On Diff #17334)

Why would you need to change extension to .supp here? I think it's fine to have two different files in this test instead of overwriting a single file.

I was mostly going for consistency, since other tests also overwrite the
files. I can revert that name change.

Want me to change the other tests too, so that they generate two files
instead of one + overwrite?

Filipe
filcab updated this revision to Diff 17383.Dec 17 2014, 2:59 AM

Fixed the *_OPTIONS definitions to account for shell interpretation of quotes.

With my first patch, the quotes would be removed by the shell in all the *_OPTIONS definitions that weren't quoted (all except TSAN_OPTIONS definitions).

samsonov accepted this revision.Dec 17 2014, 5:48 PM
samsonov edited edge metadata.

No, I'm fine with this change as-is. Thank you!

LGTM

This revision is now accepted and ready to land.Dec 17 2014, 5:48 PM
This revision was automatically updated to reflect the committed changes.