This is an archive of the discontinued LLVM Phabricator instance.

[Mips][Disassembler] Disassembler checking N64 feature instead of GP64
ClosedPublic

Authored by vmedic on Dec 15 2014, 9:20 AM.

Reviewers

Summary

The single check for N64 inside MipsDisassemblerBase's subclasses is actually wrong. It should be testing for FeatureGP64bit.

vmedic retitled this revision from to [Mips][Disassembler] Disassembler checking N64 feature instead of GP64.

vmedic updated this object.

vmedic edited the test plan for this revision. (Show Details)

vmedic added a reviewer: dsanders.

vmedic added a subscriber: Unknown Object (MLST).

LGTM

This revision is now accepted and ready to land.Dec 16 2014, 2:20 AM

Committed revision 224339.

Path

Size

lib/

Target/

Mips/

Disassembler/

8 lines

Context not available.
	MipsDisassemblerBase(const MCSubtargetInfo &STI, MCContext &Ctx,	MipsDisassemblerBase(const MCSubtargetInfo &STI, MCContext &Ctx,
	bool IsBigEndian)	bool IsBigEndian)
	: MCDisassembler(STI, Ctx),	: MCDisassembler(STI, Ctx),
	IsN64(STI.getFeatureBits() & Mips::FeatureN64),	IsGP64Bit(STI.getFeatureBits() & Mips::FeatureGP64Bit),
	IsBigEndian(IsBigEndian) {}	IsBigEndian(IsBigEndian) {}

	virtual ~MipsDisassemblerBase() {}	virtual ~MipsDisassemblerBase() {}

	bool isN64() const { return IsN64; }	bool isGP64Bit() const { return IsGP64Bit; }

	private:	private:
	bool IsN64;	bool IsGP64Bit;
	protected:	protected:
	bool IsBigEndian;	bool IsBigEndian;
	};	};
Context not available.
	unsigned RegNo,	unsigned RegNo,
	uint64_t Address,	uint64_t Address,
	const void *Decoder) {	const void *Decoder) {
	if (static_cast<const MipsDisassembler *>(Decoder)->isN64())	if (static_cast<const MipsDisassembler *>(Decoder)->isGP64Bit())
	return DecodeGPR64RegisterClass(Inst, RegNo, Address, Decoder);	return DecodeGPR64RegisterClass(Inst, RegNo, Address, Decoder);

	return DecodeGPR32RegisterClass(Inst, RegNo, Address, Decoder);	return DecodeGPR32RegisterClass(Inst, RegNo, Address, Decoder);
Context not available.