This is an archive of the discontinued LLVM Phabricator instance.

Make the platform process connect path less chatty.
ClosedPublic

Authored by sas on Dec 10 2014, 2:22 PM.

Details

Summary

If a stream contains an empty string, no need to append it to the output
(otherwise we end up with a blank line). Also, no need to print a status
message when the state changes to connected, as this string brings no
information -- "Process 0" does not mean anything to the user, and the
process being connected has no meaning either.

Diff Detail

Repository
rL LLVM

Event Timeline

sas updated this revision to Diff 17123.Dec 10 2014, 2:22 PM
sas retitled this revision from to Make the platform process connect path less chatty..
sas updated this object.
sas edited the test plan for this revision. (Show Details)
sas added reviewers: tfiala, vharron, clayborg.
sas added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Dec 11 2014, 11:16 AM
clayborg edited edge metadata.

Fine as long as all tests are passing cleanly.

This revision is now accepted and ready to land.Dec 11 2014, 11:16 AM
This revision was automatically updated to reflect the committed changes.