Page MenuHomePhabricator

[NVPTX] Fix bugs related to isSingleValueType
ClosedPublic

Authored by jingyue on Dec 8 2014, 3:39 PM.

Details

Summary

With isSingleValueType starting to treat vector types as single-value types,
code that uses this interface needs to be updated.

Diff Detail

Event Timeline

jingyue updated this revision to Diff 17057.Dec 8 2014, 3:39 PM
jingyue retitled this revision from to [NVPTX] Fix bugs related to isSingleValueType.
jingyue updated this object.
jingyue edited the test plan for this revision. (Show Details)
jingyue added a reviewer: jholewinski.
jingyue added subscribers: eliben, meheff, Unknown Object (MLST).

Added a minor inline comment.

lib/Target/NVPTX/NVPTXAsmPrinter.cpp
1352

TD->getPrefTypeAlignment(Ty) already handles vector types in a seemingly more reasonable way. For instance, if the element type of Ty is <5 x float>, the deleted code here returns 20, but getPrefTypeAlignment returns 32.

jholewinski accepted this revision.Dec 17 2014, 9:30 AM
jholewinski edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Dec 17 2014, 9:30 AM
jingyue updated this revision to Diff 17400.Dec 17 2014, 9:59 AM
jingyue edited edge metadata.

Rebase against master

The format of metadata is updated.

jingyue closed this revision.Dec 17 2014, 9:59 AM