This is an archive of the discontinued LLVM Phabricator instance.

[UBSan][MIPS] Adding support of MIPS64 in UBSan testing
ClosedPublic

Authored by slthakur on Dec 3 2014, 3:33 AM.

Details

Summary

On mips64 addresses are 40-bit. Where as a 48 bit address is used in TypeCheck/misaligned.cpp.
Using regular expression for that address.

Diff Detail

Event Timeline

slthakur updated this revision to Diff 16859.Dec 3 2014, 3:33 AM
slthakur retitled this revision from to [UBSan][MIPS] Adding support of MIPS64 in UBSan testing.
slthakur updated this object.
slthakur edited the test plan for this revision. (Show Details)
slthakur added reviewers: samsonov, kcc, dsanders, petarj.
slthakur set the repository for this revision to rL LLVM.
slthakur added subscribers: Anand.Takale, sdkie, mohit.bhakkad, Unknown Object (MLST).
samsonov added inline comments.Dec 3 2014, 4:18 PM
test/ubsan/TestCases/TypeCheck/misaligned.cpp
105

Hm, let's not overcomplicate things and just use

0x{{0+}}123

regexp for address.

slthakur updated this revision to Diff 16908.Dec 3 2014, 10:14 PM
slthakur updated this object.
slthakur set the repository for this revision to rL LLVM.
samsonov accepted this revision.Dec 4 2014, 1:01 PM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 4 2014, 1:01 PM
sdkie closed this revision.Dec 15 2014, 2:55 AM

closed by rL224242